Setting -AssessOnly does not work & does not support subfolders for ArcRemoteShare in 1.0.8

[Borgquite]

In version 1.0.8, the AssessOnly check doesn't work at all. The issues I can see are:

In ScheduledTask.xml, the ArcRemoteShare switch parameter in the Scheduled Task now has single quotations around it:

ArcEnabledServersGroupPolicy/ArcGPO/{1BAEEB14-8CB1-42FC-960B-55C4B45AFB0B}/DomainSysvol/GPO/Machine/Preferences/ScheduledTasks/ScheduledTasks.xml

Line 4 in 4ab7424

<ImmediateTaskV2 clsid="{9756B581-76EC-4169-9AFC-0CA8D43ADB5F}" name="Arc Agent Installation" image="0" changed="2021-12-15 18:30:36" uid="{1A3FC9E2-F3D5-442D-B6AD-5CDC09D2594F}" userContext="0" removePolicy="0"><Properties action="C" name="Arc Agent Installation" runAs="NT AUTHORITY\System" logonType="S4U"><Task version="1.3"><RegistrationInfo><Author>AD\admin</Author><Description></Description></RegistrationInfo><Principals><Principal id="Author"><UserId>NT AUTHORITY\System</UserId><LogonType>S4U</LogonType><RunLevel>HighestAvailable</RunLevel></Principal></Principals><Settings><IdleSettings><Duration>PT10M</Duration><WaitTimeout>PT1H</WaitTimeout><StopOnIdleEnd>true</StopOnIdleEnd><RestartOnIdle>false</RestartOnIdle></IdleSettings><MultipleInstancesPolicy>IgnoreNew</MultipleInstancesPolicy><DisallowStartIfOnBatteries>true</DisallowStartIfOnBatteries><StopIfGoingOnBatteries>true</StopIfGoingOnBatteries><AllowHardTerminate>true</AllowHardTerminate><StartWhenAvailable>true</StartWhenAvailable><AllowStartOnDemand>true</AllowStartOnDemand><Enabled>true</Enabled><Hidden>false</Hidden><ExecutionTimeLimit>P3D</ExecutionTimeLimit><Priority>7</Priority><DeleteExpiredTaskAfter>PT0S</DeleteExpiredTaskAfter></Settings><Triggers><TimeTrigger><StartBoundary>%LocalTimeXmlEx%</StartBoundary><EndBoundary>%LocalTimeXmlEx%</EndBoundary><Enabled>true</Enabled></TimeTrigger></Triggers><Actions Context="Author"><Exec><Command>PowerShell.exe</Command><Arguments>-ExecutionPolicy Bypass -Command "Copy-Item '\\{ReportServerFQDN}\{ArcRemoteShare}\AzureArcDeploy\EnableAzureArc.ps1' $ENV:TEMP -Force; &amp; $ENV:TEMP\EnableAzureArc.ps1 -ArcRemoteShare '{ArcRemoteShare}'"</Arguments></Exec><Exec><Command>PowerShell.exe</Command><Arguments>-ExecutionPolicy Bypass -Command "Remove-Item $ENV:TEMP\EnableAzureArc.ps1 -Force -ErrorAction SilentlyContinue"</Arguments></Exec></Actions></Task></Properties><Filters><FilterCollection bool="AND" not="0"><FilterOs bool="AND" not="0" class="NT" version="2K8R2" type="NE" edition="NE" sp="NE"/><FilterOs bool="OR" not="0" class="NT" version="WIN8S" type="NE" edition="NE" sp="NE"/><FilterOs bool="OR" not="0" class="NT" version="WINBLUESRV" type="NE" edition="NE" sp="NE"/><FilterOs bool="OR" not="0" class="NT" version="WINTHRESHOLDSRV" type="NE" edition="NE" sp="NE"/></FilterCollection></Filters></ImmediateTaskV2>

But the code that updates it in DeployGPO still assumes there are no single quotes (from a previous version?)

ArcEnabledServersGroupPolicy/DeployGPO.ps1

Line 179 in 4ab7424

$xmlcontent -replace "ArcRemoteShare $ArcRemoteShare", "ArcRemoteShare $ArcRemoteShare -AssessOnly" | Out-File $ScheduledTaskfile -Encoding utf8 -Force -ErrorAction Stop

In addition, if the ArcRemoteShare has a backslash in it (e.g. ShareName\FolderName to store the logs in a subfolder) then the regular expression will break.

I'll submit a PR shortly with both of these fixed.