Update generation to write ModelReaderWriterBuildableAttributes for all IPersistableModels consumed (#5366)

* Initial plan

* Update generation to write ModelReaderWriterBuildableAttributes for IPersistableModels

- Updated package references to System.ClientModel 1.5.1 and Azure.Core 1.47.1
- Added ModelReaderWriterBuildableAttributesWriter to collect IPersistableModel types
- Integrated attribute generation into DataPlaneTarget, LowLevelTarget, and MgmtTarget
- Added recursive property traversal to collect all IPersistableModel types
- Generate assembly-level attributes for deduplicated types

Co-authored-by: m-nash <[email protected]>

* Add unit tests for ModelReaderWriterBuildableAttributesWriter

- Added comprehensive unit tests for the new writer class
- Tests cover empty collections, attribute generation, and deduplication
- Validates proper ordering and format of generated attributes
- Integration tests ensure the complete generation pipeline works correctly

Co-authored-by: m-nash <[email protected]>

* Improve ModelReaderWriterBuildableAttributesWriter implementation

- Enhanced IPersistableModel detection to be more robust
- Improved property traversal to handle generic types more accurately
- Added better type filtering to avoid unnecessary processing
- Refined type checking logic for better precision

Co-authored-by: m-nash <[email protected]>

* Move ModelReaderWriterBuildableAttributes to Context class instead of separate file

Co-authored-by: m-nash <[email protected]>

* Update ModelReaderWriterBuildableAttributes to be class-level instead of assembly-level

Co-authored-by: m-nash <[email protected]>

* Improve ModelReaderWriterBuildableAttributes algorithm with better IPersistableModel detection

Co-authored-by: m-nash <[email protected]>

* update algo

* Update PostProcessor to handle invalid attributes similar to TypeSpec PR #7908

Co-authored-by: live1206 <[email protected]>

* - remove `RemoveInvalidUsings` in postProcessor since it's not working
- for inheritableCommonType, update access to `internal protected` instead of `protected`
- add resoruce types as buildableTypes for mgmt

* remove buildable attributes for internal models and add resources to buildable types

* typo

* typo

* update logic to not fail for azure identity

* regen after changes

* Revert use-model-reader-writer settings from readme.md files as they are beyond scope

Co-authored-by: JoshLove-msft <[email protected]>

* regen

* regen

* Add ResourceData and base type property types to buildable types

* regen

* fix tests

* - Skip internal models from buildable types
- Add suppression for obsolete types

* skip MRWContext from reference map builder

* keep leading trivia to keep xml docs

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: m-nash <[email protected]>
Co-authored-by: live1206 <[email protected]>
Co-authored-by: Wei Hu <[email protected]>
Co-authored-by: JoshLove-msft <[email protected]>
Co-authored-by: jolov <[email protected]>

Author: 4 people

Packages.Data.props

@@ -37,10 +37,11 @@
 
   <!-- All csproj dependencies. -->
   <ItemGroup>
-    <PackageReference Update="Azure.Core" Version="1.47.0" />
+    <PackageReference Update="Azure.Core" Version="1.47.1" />
     <PackageReference Update="Azure.Core.Experimental" Version="0.1.0-preview.18" />
     <PackageReference Update="Azure.Core.Expressions.DataFactory" Version="1.0.0" />
-    <PackageReference Update="Azure.ResourceManager" Version="1.14.0-beta.1" />
+    <PackageReference Update="Azure.Identity" Version="1.14.2" />
+    <PackageReference Update="Azure.ResourceManager" Version="1.13.2" />
     <PackageReference Update="CommandLineParser" Version="2.9.1" />
     <PackageReference Update="Humanizer.Core" Version="2.13.14" />
     <PackageReference Update="Microsoft.AspNetCore.Server.Kestrel" Version="2.2.0" />
@@ -49,9 +50,9 @@
     <PackageReference Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.1.0" />
     <PackageReference Update="NuGet.Configuration" Version="6.8.0" />
     <PackageReference Update="NUnit" Version="3.13.2" />
-    <PackageReference Update="System.ClientModel" Version="1.5.0" />
+    <PackageReference Update="System.ClientModel" Version="1.5.1" />
     <PackageReference Update="System.Diagnostics.DiagnosticSource" Version="8.0.0" />
-    <PackageReference Update="System.Memory" Version="4.5.4" />
+    <PackageReference Update="System.Memory" Version="4.5.5" />
     <PackageReference Update="System.Text.Json" Version="8.0.5" />
     <PackageReference Update="YamlDotNet" Version="11.2.1" />
   </ItemGroup>

samples/AnomalyDetector/src/Generated/Models/AnomalyDetectorContext.cs

@@ -6,13 +6,37 @@
 #nullable disable
 
 using System.ClientModel.Primitives;
+using AnomalyDetector.Models;
 
 namespace AnomalyDetector
 {
     /// <summary>
     /// Context class which will be filled in by the System.ClientModel.SourceGeneration.
     /// For more information see 'https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/System.ClientModel/src/docs/ModelReaderWriterContext.md'
     /// </summary>
+    [ModelReaderWriterBuildable(typeof(AlignPolicy))]
+    [ModelReaderWriterBuildable(typeof(AnomalyDetectionModel))]
+    [ModelReaderWriterBuildable(typeof(AnomalyInterpretation))]
+    [ModelReaderWriterBuildable(typeof(AnomalyState))]
+    [ModelReaderWriterBuildable(typeof(AnomalyValue))]
+    [ModelReaderWriterBuildable(typeof(CorrelationChanges))]
+    [ModelReaderWriterBuildable(typeof(DiagnosticsInfo))]
+    [ModelReaderWriterBuildable(typeof(ErrorResponse))]
+    [ModelReaderWriterBuildable(typeof(ModelInfo))]
+    [ModelReaderWriterBuildable(typeof(ModelState))]
+    [ModelReaderWriterBuildable(typeof(MultivariateBatchDetectionOptions))]
+    [ModelReaderWriterBuildable(typeof(MultivariateBatchDetectionResultSummary))]
+    [ModelReaderWriterBuildable(typeof(MultivariateDetectionResult))]
+    [ModelReaderWriterBuildable(typeof(MultivariateLastDetectionOptions))]
+    [ModelReaderWriterBuildable(typeof(MultivariateLastDetectionResult))]
+    [ModelReaderWriterBuildable(typeof(TimeSeriesPoint))]
+    [ModelReaderWriterBuildable(typeof(UnivariateChangePointDetectionOptions))]
+    [ModelReaderWriterBuildable(typeof(UnivariateChangePointDetectionResult))]
+    [ModelReaderWriterBuildable(typeof(UnivariateDetectionOptions))]
+    [ModelReaderWriterBuildable(typeof(UnivariateEntireDetectionResult))]
+    [ModelReaderWriterBuildable(typeof(UnivariateLastDetectionResult))]
+    [ModelReaderWriterBuildable(typeof(VariableState))]
+    [ModelReaderWriterBuildable(typeof(VariableValues))]
     public partial class AnomalyDetectorContext : ModelReaderWriterContext
     {
     }

samples/AzureSample.ResourceManager.Sample/src/Generated/Models/AzureSampleResourceManagerSampleContext.cs

@@ -6,13 +6,179 @@
 #nullable disable
 
 using System.ClientModel.Primitives;
+using Azure.ResourceManager.Models;
+using AzureSample.ResourceManager.Sample.Models;
 
 namespace AzureSample.ResourceManager.Sample
 {
     /// <summary>
     /// Context class which will be filled in by the System.ClientModel.SourceGeneration.
     /// For more information see 'https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/System.ClientModel/src/docs/ModelReaderWriterContext.md'
     /// </summary>
+    [ModelReaderWriterBuildable(typeof(AdditionalUnattendContent))]
+    [ModelReaderWriterBuildable(typeof(ApiError))]
+    [ModelReaderWriterBuildable(typeof(ApiErrorBase))]
+    [ModelReaderWriterBuildable(typeof(AutomaticOSUpgradePolicy))]
+    [ModelReaderWriterBuildable(typeof(AutomaticRepairsPolicy))]
+    [ModelReaderWriterBuildable(typeof(AvailabilitySetData))]
+    [ModelReaderWriterBuildable(typeof(AvailabilitySetListResult))]
+    [ModelReaderWriterBuildable(typeof(AvailabilitySetPatch))]
+    [ModelReaderWriterBuildable(typeof(AvailabilitySetResource))]
+    [ModelReaderWriterBuildable(typeof(AvailablePatchSummary))]
+    [ModelReaderWriterBuildable(typeof(AzureSampleResourceManagerSamplePlan))]
+    [ModelReaderWriterBuildable(typeof(AzureSampleResourceManagerSampleSku))]
+    [ModelReaderWriterBuildable(typeof(AzureSampleResourceManagerSampleUsage))]
+    [ModelReaderWriterBuildable(typeof(AzureSampleResourceManagerSampleUsageName))]
+    [ModelReaderWriterBuildable(typeof(BootDiagnostics))]
+    [ModelReaderWriterBuildable(typeof(BootDiagnosticsInstanceView))]
+    [ModelReaderWriterBuildable(typeof(DataDisk))]
+    [ModelReaderWriterBuildable(typeof(DataDiskImage))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostAllocatableVm))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostData))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostGroupData))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostGroupListResult))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostGroupPatch))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostGroupResource))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostInstanceView))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostInstanceViewWithName))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostListResult))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostPatch))]
+    [ModelReaderWriterBuildable(typeof(DedicatedHostResource))]
+    [ModelReaderWriterBuildable(typeof(DiffDiskSettings))]
+    [ModelReaderWriterBuildable(typeof(DiskEncryptionSettings))]
+    [ModelReaderWriterBuildable(typeof(DiskInstanceView))]
+    [ModelReaderWriterBuildable(typeof(ImageData))]
+    [ModelReaderWriterBuildable(typeof(ImageDataDisk))]
+    [ModelReaderWriterBuildable(typeof(ImageDisk))]
+    [ModelReaderWriterBuildable(typeof(ImageListResult))]
+    [ModelReaderWriterBuildable(typeof(ImageOSDisk))]
+    [ModelReaderWriterBuildable(typeof(ImagePatch))]
+    [ModelReaderWriterBuildable(typeof(ImageReference))]
+    [ModelReaderWriterBuildable(typeof(ImageResource))]
+    [ModelReaderWriterBuildable(typeof(ImageStorageProfile))]
+    [ModelReaderWriterBuildable(typeof(InnerError))]
+    [ModelReaderWriterBuildable(typeof(InstanceViewStatus))]
+    [ModelReaderWriterBuildable(typeof(KeyVaultKeyReference))]
+    [ModelReaderWriterBuildable(typeof(KeyVaultSecretReference))]
+    [ModelReaderWriterBuildable(typeof(LastPatchInstallationSummary))]
+    [ModelReaderWriterBuildable(typeof(LinuxConfiguration))]
+    [ModelReaderWriterBuildable(typeof(ListUsagesResult))]
+    [ModelReaderWriterBuildable(typeof(LogAnalytics))]
+    [ModelReaderWriterBuildable(typeof(LogAnalyticsInputBase))]
+    [ModelReaderWriterBuildable(typeof(MaintenanceRedeployStatus))]
+    [ModelReaderWriterBuildable(typeof(ManagedDiskParameters))]
+    [ModelReaderWriterBuildable(typeof(NetworkInterfaceReference))]
+    [ModelReaderWriterBuildable(typeof(OrchestrationServiceStateContent))]
+    [ModelReaderWriterBuildable(typeof(OrchestrationServiceSummary))]
+    [ModelReaderWriterBuildable(typeof(OSDisk))]
+    [ModelReaderWriterBuildable(typeof(OSProfile))]
+    [ModelReaderWriterBuildable(typeof(ProximityPlacementGroupData))]
+    [ModelReaderWriterBuildable(typeof(ProximityPlacementGroupListResult))]
+    [ModelReaderWriterBuildable(typeof(ProximityPlacementGroupPatch))]
+    [ModelReaderWriterBuildable(typeof(ProximityPlacementGroupResource))]
+    [ModelReaderWriterBuildable(typeof(PurchasePlan))]
+    [ModelReaderWriterBuildable(typeof(RecoveryWalkResponse))]
+    [ModelReaderWriterBuildable(typeof(RequestRateByIntervalContent))]
+    [ModelReaderWriterBuildable(typeof(RetrieveBootDiagnosticsDataResult))]
+    [ModelReaderWriterBuildable(typeof(RollbackStatusInfo))]
+    [ModelReaderWriterBuildable(typeof(RollingUpgradePolicy))]
+    [ModelReaderWriterBuildable(typeof(RollingUpgradeProgressInfo))]
+    [ModelReaderWriterBuildable(typeof(RollingUpgradeRunningStatus))]
+    [ModelReaderWriterBuildable(typeof(SshPublicKeyData))]
+    [ModelReaderWriterBuildable(typeof(SshPublicKeyGenerateKeyPairResult))]
+    [ModelReaderWriterBuildable(typeof(SshPublicKeyInfo))]
+    [ModelReaderWriterBuildable(typeof(SshPublicKeyPatch))]
+    [ModelReaderWriterBuildable(typeof(SshPublicKeyResource))]
+    [ModelReaderWriterBuildable(typeof(SshPublicKeysGroupListResult))]
+    [ModelReaderWriterBuildable(typeof(StorageProfile))]
+    [ModelReaderWriterBuildable(typeof(SubResource))]
+    [ModelReaderWriterBuildable(typeof(SubResourceReadOnly))]
+    [ModelReaderWriterBuildable(typeof(SubResourceWithColocationStatus))]
+    [ModelReaderWriterBuildable(typeof(SubscriptionResourceGetVirtualMachineImagesOptions))]
+    [ModelReaderWriterBuildable(typeof(SystemData))]
+    [ModelReaderWriterBuildable(typeof(TerminateNotificationProfile))]
+    [ModelReaderWriterBuildable(typeof(ThrottledRequestsContent))]
+    [ModelReaderWriterBuildable(typeof(UpdateResource))]
+    [ModelReaderWriterBuildable(typeof(UpgradeOperationHistoricalStatusInfo))]
+    [ModelReaderWriterBuildable(typeof(UpgradeOperationHistoricalStatusInfoProperties))]
+    [ModelReaderWriterBuildable(typeof(UpgradeOperationHistoryStatus))]
+    [ModelReaderWriterBuildable(typeof(UpgradePolicy))]
+    [ModelReaderWriterBuildable(typeof(VaultCertificate))]
+    [ModelReaderWriterBuildable(typeof(VaultSecretGroup))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineAgentInstanceView))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineAssessPatchesResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineCaptureContent))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineCaptureResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineData))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineExtensionData))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineExtensionHandlerInstanceView))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineExtensionImageData))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineExtensionImageResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineExtensionInstanceView))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineExtensionResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineExtensionUpdate))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineImage))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineImageResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineInstanceView))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineListResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachinePatch))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachinePatchStatus))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineReimageContent))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetData))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetDataDisk))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionData))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionListResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionPatch))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetExtensionResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetInstanceView))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetIPConfiguration))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetIPTag))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetListOSUpgradeHistory))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetListResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetListSkusResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetListWithLinkResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetManagedDiskParameters))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetNetworkConfiguration))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetNetworkProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetOSDisk))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetOSProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetPatch))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetPublicIPAddressConfiguration))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetReimageContent))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetRollingUpgradeData))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetRollingUpgradeResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetSku))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetSkuCapacity))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetStorageProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateIPConfiguration))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateNetworkConfiguration))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateNetworkProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateOSDisk))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateOSProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdatePublicIPAddressConfiguration))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateStorageProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetUpdateVmProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVirtualMachineExtensionResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmData))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmExtensionsSummary))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmInstanceIds))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmInstanceRequiredIds))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmInstanceView))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmListResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmProfile))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmProtectionPolicy))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmReimageContent))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineScaleSetVmResource))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineSize))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineSizeListResult))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineSoftwarePatchProperties))]
+    [ModelReaderWriterBuildable(typeof(VirtualMachineStatusCodeCount))]
+    [ModelReaderWriterBuildable(typeof(VmScaleSetConvertToSinglePlacementGroupContent))]
+    [ModelReaderWriterBuildable(typeof(WindowsConfiguration))]
+    [ModelReaderWriterBuildable(typeof(WinRMListener))]
     public partial class AzureSampleResourceManagerSampleContext : ModelReaderWriterContext
     {
     }