{AKS} Fix missing wait on LRO pollers in azuremonitormetrics helpers

create_dce, create_dcr, create_dcra, addon_put, create_default_mac and
link_grafana_instance all call begin_create_or_update[_by_id] but never
call .result()/.wait() on the returned poller before returning. Since the
generic ResourceManagementClient used here polls via a background thread,
the calling code proceeds as soon as the initial PUT is accepted, without
waiting for the resource to actually finish provisioning.

This is normally invisible in VCR-recorded tests (responses replay
instantly), but is exposed in live tests: azure-cli-testsdk's tearDown()
asserts that no thread named "LROPoller" is still alive
(scenario_tests/base.py), which fails when a live 'az aks create --sku
automatic' run leaves one of these pollers still polling in the
background after the command returns.

Fix: capture the poller returned by each begin_create_or_update[_by_id]
call and call .result() on it before returning, so callers only get
control back once the resource has actually finished provisioning.

Author: FumingZhang

src/azure-cli/azure/cli/command_modules/acs/azuremonitormetrics/addonput.py

@@ -22,6 +22,7 @@ def addon_put(cmd, cluster_subscription, cluster_resource_group_name, cluster_na
             if getattr(mc.azure_monitor_profile.metrics, "enabled", None) is False:
                 mc.azure_monitor_profile.metrics.enabled = True
     try:
-        client.begin_create_or_update(cluster_resource_group_name, cluster_name, mc)
+        poller = client.begin_create_or_update(cluster_resource_group_name, cluster_name, mc)
+        poller.result()
     except Exception as e:
         raise UnknownError(e)

src/azure-cli/azure/cli/command_modules/acs/azuremonitormetrics/amg/link.py

@@ -69,11 +69,12 @@ def link_grafana_instance(cmd, raw_parameters, azure_monitor_workspace_resource_
             }
         }
         try:
-            resources.begin_create_or_update_by_id(
+            poller = resources.begin_create_or_update_by_id(
                 roleAssignmentResourceId,
                 GRAFANA_ROLE_ASSIGNMENT_API,
                 association_body
             )
+            poller.result()
         except HttpResponseError as e:
             # If already exists (RoleAssignmentExists), warn and continue, else print error
             if e.error and e.error.code == "RoleAssignmentExists":
@@ -109,11 +110,12 @@ def link_grafana_instance(cmd, raw_parameters, azure_monitor_workspace_resource_
         targetGrafanaArmPayload["properties"]["grafanaIntegrations"]["azureMonitorWorkspaceIntegrations"].append({
             "azureMonitorWorkspaceResourceId": azure_monitor_workspace_resource_id
         })
-        resources.begin_create_or_update_by_id(
+        poller = resources.begin_create_or_update_by_id(
             grafana_resource_id,
             GRAFANA_API,
             targetGrafanaArmPayload
         )
+        poller.result()
     except CLIError as e:
         raise CLIError(e)
     return GrafanaLink.SUCCESS

src/azure-cli/azure/cli/command_modules/acs/azuremonitormetrics/amw/create.py

@@ -34,14 +34,15 @@ def create_default_mac(cmd, cluster_subscription, cluster_region):
     else:
         resource_groups.create_or_update(default_resource_group_name, {"location": default_mac_region})
     try:
-        resources.begin_create_or_update_by_id(
+        poller = resources.begin_create_or_update_by_id(
             azure_monitor_workspace_resource_id,
             MAC_API,
             {
                 "location": default_mac_region,
                 "properties": {}
             }
         )
+        poller.result()
         return azure_monitor_workspace_resource_id, default_mac_region
     except Exception as e:
         raise CLIError(e)

src/azure-cli/azure/cli/command_modules/acs/azuremonitormetrics/dc/dce_api.py

@@ -20,7 +20,7 @@ def create_dce(cmd, cluster_subscription, cluster_resource_group_name, cluster_n
     from azure.cli.command_modules.acs._client_factory import get_resources_client
     resources = get_resources_client(cmd.cli_ctx, cluster_subscription)
     try:
-        resources.begin_create_or_update_by_id(
+        poller = resources.begin_create_or_update_by_id(
             dce_resource_id,
             DC_API,
             {
@@ -30,6 +30,7 @@ def create_dce(cmd, cluster_subscription, cluster_resource_group_name, cluster_n
                 "properties": {}
             }
         )
+        poller.result()
         return dce_resource_id
     except Exception as error:
         raise CLIError(error)

src/azure-cli/azure/cli/command_modules/acs/azuremonitormetrics/dc/dcr_api.py

@@ -33,11 +33,12 @@ def create_dcr(cmd, mac_region, azure_monitor_workspace_resource_id, cluster_sub
         }
     }
     try:
-        resources.begin_create_or_update_by_id(
+        poller = resources.begin_create_or_update_by_id(
             dcr_resource_id,
             DC_API,
             dcr_creation_body
         )
+        poller.result()
         return dcr_resource_id
     except Exception as error:
         raise CLIError(error)

src/azure-cli/azure/cli/command_modules/acs/azuremonitormetrics/dc/dcra_api.py

@@ -31,11 +31,12 @@ def create_dcra(cmd, cluster_region, cluster_subscription, cluster_resource_grou
     from azure.cli.command_modules.acs._client_factory import get_resources_client
     resources = get_resources_client(cmd.cli_ctx, cluster_subscription)
     try:
-        resources.begin_create_or_update_by_id(
+        poller = resources.begin_create_or_update_by_id(
             f"{cluster_resource_id}/providers/Microsoft.Insights/dataCollectionRuleAssociations/{dcra_name}",
             DC_API,
             association_body
         )
+        poller.result()
         return dcra_resource_id
     except Exception as error:
         raise CLIError(error)