Rename body parameter in resource methods. (#53492)

* rename body parameter in resource methods.

* refine.

* address review comments.

* regen after rebase.

* address review comments.

Author: haiyuazhang

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/ExtensionProvider.cs

@@ -114,7 +114,7 @@ private MethodProvider BuildRedirectMethod(CSharpType coreType, MethodProvider t
 
             foreach (var p in methodSignature.Parameters)
             {
-                var normalizedName = BodyParameterNameNormalizer.GetNormalizedParameterNameForNonResourceMethod(p);
+                var normalizedName = BodyParameterNameNormalizer.GetNormalizedBodyParameterName(p);
                 if (normalizedName != null)
                 {
                     p.Update(name: normalizedName);

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/MockableResourceProvider.cs

@@ -205,7 +205,7 @@ protected override MethodProvider[] BuildMethods()
                     var updated = false;
                     foreach (var p in m.Signature.Parameters)
                     {
-                        var normalizedName = BodyParameterNameNormalizer.GetNormalizedParameterNameForNonResourceMethod(p);
+                        var normalizedName = BodyParameterNameNormalizer.GetNormalizedBodyParameterName(p);
                         if (normalizedName != null)
                         {
                             p.Update(name: normalizedName);

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/BodyParameterNameNormalizer.cs

@@ -15,7 +15,7 @@ internal static class BodyParameterNameNormalizer
         /// </summary>
         /// <param name="parameter">The parameter to normalize.</param>
         /// <returns>The normalized parameter name, or null if no normalization is needed.</returns>
-        public static string? GetNormalizedParameterNameForNonResourceMethod(ParameterProvider parameter)
+        public static string? GetNormalizedBodyParameterName(ParameterProvider parameter)
         {
             if (parameter.Location != ParameterLocation.Body || !parameter.Type.IsModelType())
             {

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/OperationMethodParameterHelper.cs

@@ -55,6 +55,17 @@ public static IReadOnlyList<ParameterProvider> GetOperationMethodParameters(
                     outputParameter.Update(name: "data");
                 }
 
+                // Rename body parameters for resource/resourcecollection operations
+                if ((enclosingTypeProvider is ResourceClientProvider or ResourceCollectionClientProvider) &&
+                    (serviceMethod.Operation.HttpMethod == "PUT" || serviceMethod.Operation.HttpMethod == "POST" || serviceMethod.Operation.HttpMethod == "PATCH"))
+                {
+                    var normalizedName = BodyParameterNameNormalizer.GetNormalizedBodyParameterName(outputParameter);
+                    if (normalizedName != null)
+                    {
+                        outputParameter.Update(name: normalizedName);
+                    }
+                }
+
                 if (parameter.IsRequired)
                 {
                     requiredParameters.Add(outputParameter);

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/NameVisitor.cs

@@ -46,7 +46,6 @@ internal class NameVisitor : ScmLibraryVisitor
             "PrivateLinkResourceListResult"
         };
 
-    private readonly HashSet<CSharpType> _resourceUpdateModelTypes = new();
     private readonly Dictionary<MrwSerializationTypeDefinition, string> _deserializationRename = new();
 
     protected override EnumProvider? PreVisitEnum(InputEnumType enumType, EnumProvider? type)
@@ -90,12 +89,6 @@ internal class NameVisitor : ScmLibraryVisitor
             newName = $"{enclosingResourceName}Patch";
             UpdateSerialization(type, newName, type.Name);
             type.Update(name: newName);
-
-            _resourceUpdateModelTypes.Add(type.Type);
-            foreach (var serializationProvider in type.SerializationProviders)
-            {
-                _resourceUpdateModelTypes.Add(serializationProvider.Type);
-            }
         }
         return base.PreVisitModel(model, type);
     }
@@ -213,22 +206,6 @@ private void DoPreVisitPropertyNameRenaming(InputProperty property, PropertyProv
 
     protected override MethodProvider? VisitMethod(MethodProvider method)
     {
-        var parameterUpdated = false;
-        foreach (var parameter in method.Signature.Parameters)
-        {
-            if (_resourceUpdateModelTypes.Contains(parameter.Type))
-            {
-                parameter.Update(name: "patch");
-                parameterUpdated = true;
-            }
-        }
-
-        if (parameterUpdated)
-        {
-            // This is required as a workaround to update documentation for the method signature
-            method.Update(signature: method.Signature);
-        }
-
         // TODO: we will remove this manual updated when https://github.com/microsoft/typespec/issues/8079 is resolved
         if (method.EnclosingType is MrwSerializationTypeDefinition serializationTypeDefinition && _deserializationRename.TryGetValue(serializationTypeDefinition, out var newName) && method.Signature.Name.StartsWith("Deserialize"))
         {