Same variable in test code was used to represent two different classes (#44183)

Author: dargilco

sdk/ai/azure-ai-projects/.env.template

@@ -28,8 +28,23 @@ AZURE_AI_PROJECTS_AZURE_AOAI_ACCOUNT=
 AZURE_AI_CHAT_MODEL_DEPLOYMENT_NAME=
 AZURE_AI_EMBEDDING_MODEL_DEPLOYMENT_NAME=
 
+# Used in Agent tools samples
+BING_PROJECT_CONNECTION_ID=
+MCP_PROJECT_CONNECTION_ID=
+FABRIC_PROJECT_CONNECTION_ID=
+AI_SEARCH_PROJECT_CONNECTION_ID=
+AI_SEARCH_INDEX_NAME=
+BING_CUSTOM_SEARCH_PROJECT_CONNECTION_ID=
+BING_CUSTOM_SEARCH_INSTANCE_NAME=
+SHAREPOINT_PROJECT_CONNECTION_ID=
+A2A_PROJECT_CONNECTION_ID=
+BROWSER_AUTOMATION_PROJECT_CONNECTION_ID=
+OPENAPI_PROJECT_CONNECTION_ID=
+
 #######################################################################
 #
+# Used in tests
+
 # Used tests, excluding Agent tests
 AZURE_AI_PROJECTS_TESTS_PROJECT_ENDPOINT=
 
@@ -53,19 +68,6 @@ AZURE_AI_PROJECTS_TESTS_MCP_PROJECT_CONNECTION_ID=
 # Used in Image generation agent tools tests
 AZURE_AI_PROJECTS_TESTS_IMAGE_MODEL_DEPLOYMENT_NAME=
 
-# Used in tools
-BING_PROJECT_CONNECTION_ID=
-MCP_PROJECT_CONNECTION_ID=
-FABRIC_PROJECT_CONNECTION_ID=
-AI_SEARCH_PROJECT_CONNECTION_ID=
-AI_SEARCH_INDEX_NAME=
-BING_CUSTOM_SEARCH_PROJECT_CONNECTION_ID=
-BING_CUSTOM_SEARCH_INSTANCE_NAME=
-SHAREPOINT_PROJECT_CONNECTION_ID=
-A2A_PROJECT_CONNECTION_ID=
-BROWSER_AUTOMATION_PROJECT_CONNECTION_ID=
-OPENAPI_PROJECT_CONNECTION_ID=
-
 # Used in Fine-tuning tests
 AZURE_AI_PROJECTS_TESTS_COMPLETED_OAI_MODEL_SFT_FINE_TUNING_JOB_ID=
 AZURE_AI_PROJECTS_TESTS_COMPLETED_OAI_MODEL_RFT_FINE_TUNING_JOB_ID=

sdk/ai/azure-ai-projects/tests/agents/test_agents_crud.py

@@ -83,17 +83,17 @@ def test_agents_crud(self, **kwargs):
         )
 
         # Retrieve specific versions of the first Agent
-        retrieved_agent: AgentVersionDetails = project_client.agents.get_version(
+        retrieved_agent_version: AgentVersionDetails = project_client.agents.get_version(
             agent_name=first_agent_name, agent_version=agent1_version1.version
         )
         self._validate_agent_version(
-            retrieved_agent, expected_name=first_agent_name, expected_version=agent1_version1.version
+            retrieved_agent_version, expected_name=first_agent_name, expected_version=agent1_version1.version
         )
-        retrieved_agent: AgentVersionDetails = project_client.agents.get_version(
+        retrieved_agent_version: AgentVersionDetails = project_client.agents.get_version(
             agent_name=first_agent_name, agent_version=agent1_version2.version
         )
         self._validate_agent_version(
-            retrieved_agent, expected_name=first_agent_name, expected_version=agent1_version2.version
+            retrieved_agent_version, expected_name=first_agent_name, expected_version=agent1_version2.version
         )
 
         # List all versions of the first Agent (three should be at least two, per the above..)

sdk/ai/azure-ai-projects/tests/agents/test_agents_crud_async.py

@@ -74,17 +74,17 @@ async def test_agents_crud_async(self, **kwargs):
             )
 
             # Retrieve specific versions of the first Agent
-            retrieved_agent: AgentVersionDetails = await project_client.agents.get_version(
+            retrieved_agent_version: AgentVersionDetails = await project_client.agents.get_version(
                 agent_name=first_agent_name, agent_version=agent1_version1.version
             )
             self._validate_agent_version(
-                retrieved_agent, expected_name=first_agent_name, expected_version=agent1_version1.version
+                retrieved_agent_version, expected_name=first_agent_name, expected_version=agent1_version1.version
             )
-            retrieved_agent: AgentVersionDetails = await project_client.agents.get_version(
+            retrieved_agent_version: AgentVersionDetails = await project_client.agents.get_version(
                 agent_name=first_agent_name, agent_version=agent1_version2.version
             )
             self._validate_agent_version(
-                retrieved_agent, expected_name=first_agent_name, expected_version=agent1_version2.version
+                retrieved_agent_version, expected_name=first_agent_name, expected_version=agent1_version2.version
             )
 
             # List all versions of the first Agent (three should be at least two, per the above..)