Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Handle MSAL string response scenario #40281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Identity] Handle MSAL string response scenario #40281

wants to merge 1 commit into from
+29 −1

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Mar 29, 2025

Closes: #40240

@pvaneck pvaneck requested a review from Copilot March 29, 2025 00:30
Copilot
Copilot AI reviewed Mar 29, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve error handling in the MSAL client when the response content is a string rather than a dictionary.

  • Added a new test to verify that MSAL string error responses are properly handled.
  • Updated the error storage logic in the MSAL client to account for non-dictionary content.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
sdk/identity/azure-identity/tests/test_msal_client.py Adds a test to validate string error response handling
sdk/identity/azure-identity/azure/identity/_internal/msal_client.py Adjusts error extraction logic to handle string responses

@pvaneck pvaneck force-pushed the identity-msal-error-string branch from ec10dbc to 78a4f47 Compare March 29, 2025 00:34
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@pvaneck pvaneck marked this pull request as ready for review April 1, 2025 21:18
@pvaneck pvaneck requested review from xiangyan99 and a team as code owners April 1, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner automatically assigned from Azure/azure-sdk-write-identity

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Identity] Errors handling non-dictionary content type in proxy scenarios
2 participants
@pvaneck @azure-sdk