Do semver checking in a separate job

Author: danieljurek

eng/cgmanifest.json

@@ -0,0 +1,13 @@
+{
+  "$schema": "https://json.schemastore.org/component-detection-manifest.json",
+  "version": 1,
+  "registrations": [
+    {
+      "component": {
+        "type": "cargo",
+        "cargo": { "name": "cargo-semver-checks", "version": "0.45.0" }
+      },
+      "developmentDependency": true
+    }
+  ]
+}

eng/pipelines/templates/jobs/ci.tests.yml

@@ -58,26 +58,6 @@ jobs:
       ServiceDirectory: ${{ parameters.ServiceDirectory }}
       PackageInfoDirectory: $(Build.ArtifactStagingDirectory)/PackageInfo
 
-  - task: Cache@2
-    displayName: Cache cargo bin directory
-    inputs:
-      key: '"cargo-bin" | eng/cgmanifest.json | "$(OSVmImage)" | "$(RustToolchainName)"'
-      path: ~/.cargo/bin
-
-  - task: PowerShell@2
-    displayName: Check SemVer compatibility
-    condition: >-
-      and(
-        succeeded(),
-        ne(variables['NoPackagesChanged'],'true'),
-        eq(variables['RustToolchainName'], 'stable')
-      )
-    inputs:
-      pwsh: true
-      filePath: $(Build.SourcesDirectory)/eng/scripts/Test-Semver.ps1
-      arguments: >
-        -PackageInfoDirectory '$(Build.ArtifactStagingDirectory)/PackageInfo'
-
   - ${{ if eq(parameters.TestProxy, true) }}:
     - template: /eng/common/testproxy/test-proxy-standalone-tool.yml
 

eng/pipelines/templates/jobs/ci.yml

@@ -32,6 +32,10 @@ jobs:
     Toolchain: stable
     TimeoutInMinutes: ${{ parameters.TestTimeoutInMinutes }}
 
+- template: /eng/pipelines/templates/jobs/semver.yml
+  parameters:
+    ServiceDirectory: ${{ parameters.ServiceDirectory }}
+
 - template: /eng/common/pipelines/templates/jobs/generate-job-matrix.yml
   parameters:
     JobTemplatePath: /eng/pipelines/templates/jobs/ci.tests.yml

eng/pipelines/templates/jobs/semver.yml

@@ -0,0 +1,46 @@
+parameters:
+- name: ServiceDirectory
+  type: string
+
+jobs:
+- job: Semver
+  displayName: Semver Check
+  condition: and(succeeded(), ne(variables['Skip.Semver'], 'true'))
+
+  pool:
+    os: linux
+    name: $(LINUXPOOL)
+    image: $(LINUXVMIMAGE)
+
+  steps:
+  - template: /eng/common/pipelines/templates/steps/sparse-checkout.yml
+    parameters:
+      paths:
+      - "/*"
+
+  - template: /eng/pipelines/templates/steps/use-rust.yml@self
+    parameters:
+      Toolchain: stable
+
+  - template: /eng/pipelines/templates/steps/vcpkg.yml
+
+  - template: /eng/common/pipelines/templates/steps/set-default-branch.yml@self
+
+  - template: /eng/common/pipelines/templates/steps/save-package-properties.yml@self
+    parameters:
+      ServiceDirectory: ${{ parameters.ServiceDirectory }}
+      PackageInfoDirectory: $(Build.ArtifactStagingDirectory)/PackageInfo
+
+  - task: PowerShell@2
+    displayName: Check SemVer compatibility
+    condition: >-
+      and(
+        succeeded(),
+        ne(variables['NoPackagesChanged'],'true'),
+        eq(variables['RustToolchainName'], 'stable')
+      )
+    inputs:
+      pwsh: true
+      filePath: $(Build.SourcesDirectory)/eng/scripts/Test-Semver.ps1
+      arguments: >
+        -PackageInfoDirectory '$(Build.ArtifactStagingDirectory)/PackageInfo'

eng/scripts/Test-Semver.ps1

@@ -6,7 +6,8 @@ param(
   [Parameter(ParameterSetName = 'Named')]
   [string[]]$PackageNames,
   [Parameter(ParameterSetName = 'PackageInfo')]
-  [string]$PackageInfoDirectory
+  [string]$PackageInfoDirectory,
+  [switch]$IgnoreCgManfiestVersion
 )
 
 . ([System.IO.Path]::Combine($PSScriptRoot, '..', 'common', 'scripts', 'common.ps1'))
@@ -44,9 +45,22 @@ function Get-OutputPackageNames($workspacePackages) {
 $packages = Get-CargoPackages
 $outputPackageNames = Get-OutputPackageNames $packages
 
-LogGroupStart "cargo install cargo-semver-checks"
-Write-Host "cargo install cargo-semver-checks"
-cargo install cargo-semver-checks --locked
+# Read version from cgmanifest.json. If ignored the currently installed or
+# "latest" version is used.
+$versionParams = @()
+if (!$IgnoreCgManfiestVersion) {
+  $versionParams += '--version'
+  $cgManfiest = Get-Content ([System.IO.Path]::Combine($PSScriptRoot, '..', 'cgmanifest.json')) `
+  | ConvertFrom-Json
+  $versionParams += $cgManfiest.
+  registrations.
+  Where({ $_.component.type -eq 'cargo' -and $_.component.cargo.name -eq 'cargo-semver-checks' }).
+  component.cargo.version
+}
+
+LogGroupStart "cargo install cargo-semver-checks $($versionParams -join ' ')"
+Write-Host "cargo install cargo-semver-checks $($versionParams -join ' ')"
+cargo install cargo-semver-checks --locked @versionParams
 LogGroupEnd
 
 $packageParams = @()