-
Notifications
You must be signed in to change notification settings - Fork 319
Fix servicebus metadata #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix servicebus metadata #3396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a build and test pipeline issue where the servicebus package was being excluded from automation due to having publish = false in its Cargo.toml, causing the pipeline to fail when no publishable packages were found in the service directory.
Key Changes:
- Changed
publish = falsetopublish = truein the servicebus Cargo.toml to make the package discoverable by the build system - Added defensive error handling in the PowerShell script to log when no publishable packages are found
- Cleaned up trailing whitespace in the PowerShell script
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/servicebus/azure_messaging_servicebus/Cargo.toml | Changed package from non-publishable to publishable, allowing it to be included in build and test pipelines |
| eng/scripts/Language-Settings.ps1 | Added error logging when no publishable packages are found and removed trailing whitespace |
Co-authored-by: Copilot <[email protected]>
…"test" as a differentiated part of the name
…control flow, but an empty list of packages might not be an error)
…o pack non-publishable crate in release
Example failure attempting to publish a package that has
publish = false: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5643808&view=logs&j=b766ebde-1fdb-5f11-1350-46ddc53b23cf&t=7ef29fa0-f532-5653-3473-16dc04608431Example success building crate where
publish = false: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5643777&view=results