Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Application Gateway missing the family in SKU #4407

Open
1 task done
aavdberg opened this issue Feb 7, 2025 · 7 comments
Open
1 task done

[AVM Module Issue]: Application Gateway missing the family in SKU #4407

aavdberg opened this issue Feb 7, 2025 · 7 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@aavdberg
Copy link

aavdberg commented Feb 7, 2025

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/network/application-gateway

(Optional) Module Version

No response

Description

In the AVM module missing the family of SKU property

Image

Look how it's looking in the resourcetype from microsoft. https://learn.microsoft.com/en-us/azure/templates/microsoft.network/applicationgateways?pivots=deployment-language-bicep#applicationgatewaysku

Image

(Optional) Correlation Id

No response

@aavdberg aavdberg added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 7, 2025

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Feb 7, 2025
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Feb 7, 2025
Copy link

@aavdberg, thanks for submitting this issue for the avm/res/network/application-gateway module!

Important

A member of the @Azure/avm-res-network-applicationgateway-module-owners-bicep or @Azure/avm-res-network-applicationgateway-module-contributors-bicep team will review it soon!

@aavdberg
Copy link
Author

aavdberg commented Feb 7, 2025

@ilhaan how to update this?

@ilhaan
Copy link
Member

ilhaan commented Feb 8, 2025

@aavdberg The link you posted navigates to an issue search page with no results for this repo.

The family property seems to have been introduced in a newer API version of Microsoft.Network/applicationGateways. The AVM module is currently on 2023-04-01 which does not have family property for SKU: https://learn.microsoft.com/en-us/azure/templates/microsoft.network/2023-04-01/applicationgateways?pivots=deployment-language-bicep. See code here

So the first step to update will be to update the API version and run the automated tests to make sure the API version update does not break anything else.

You can find contribution gudiance here: https://azure.github.io/Azure-Verified-Modules/contributing/

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Feb 13, 2025

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Caution

**This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. **

Tip

  • To avoid this rule being (re)triggered, the "Needs: Triage 🔍" and "Status: Response Overdue 🚩" labels must be removed when the issue is first responded to!
  • Remove the "Needs: Immediate Attention ‼️" label once the issue has been responded to.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Status: Needs: Triage
Development

No branches or pull requests

2 participants