Number of parameters for install.sh in CMakeLists.txt does not match required number

[AndreRicardo-Zoetis]

Expected Behavior

CMakelist.txt mentions 4 variables ${ADUC_CONF_FOLDER} ${ADUC_CONF_FILE} ${ADUC_LOG_FOLDER} ${ADUC_DATA_FOLDER}

iot-hub-device-update/daemon/CMakeLists.txt

Line 10 in 3e95b9a

CODE "execute_process (COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/install.sh ${ADUC_CONF_FOLDER} ${ADUC_CONF_FILE} ${ADUC_LOG_FOLDER} ${ADUC_DATA_FOLDER})"

but install.sh expects 5 variables

iot-hub-device-update/daemon/install.sh

Line 15 in 3e95b9a

echo "Usage: install.sh configuration_dir configuration_file home_dir log_dir data_dir"

Seems that home_dir variable is missing.

Does it map to ADUC_HOME_FOLDER ?

Current Behavior

Error on install

$ sudo cmake --build . --target install
[0/1] Install the project...
-- Install configuration: "Debug"
-- Installing: /usr/local/lib/systemd/system/deviceupdate-agent.service
Usage: install.sh configuration_dir configuration_file home_dir log_dir data_dir
Expected 5 command line args, but got 4

Steps to Reproduce

Provide a detailed set of steps to reproduce the bug.

1. ./scripts/build.sh -c -u --build-packages
2. cd out
3. sudo cmake --build . --target install

Device Information

• Host OS [e.g. Ubuntu 18.04, Windows Server IoT 2019]:
  Debian 11
• Architecture [e.g. amd64, arm32, arm64]:
  amd64
• Provisioning Method:
  N/A
  *DU Agent Version (run 'sudo -u adu /usr/bin/AducIotAgent -v'):

Logs

$ sudo cmake --build . --target install
[0/1] Install the project...
-- Install configuration: "Debug"
-- Installing: /usr/local/lib/systemd/system/deviceupdate-agent.service
Usage: install.sh configuration_dir configuration_file home_dir log_dir data_dir
Expected 5 command line args, but got 4
Create the 'adu' group.
Error: 'adu' group already exists.
-- Installing: /usr/local/bin/AducIotAgent
-- Set runtime path of "/usr/local/bin/AducIotAgent" to ""
-- Installing: /usr/local/bin/adu-shell
-- Installing: /usr/local/bin/adu-swupdate.sh
-- Installing: /var/lib/adu/extensions/sources/libcurl_content_downloader.so
-- Installing: /var/lib/adu/extensions/sources/libdeliveryoptimization_content_downloader.so
-- Set runtime path of "/var/lib/adu/extensions/sources/libdeliveryoptimization_content_downloader.so" to ""
-- Installing: /var/lib/adu/extensions/sources/libcontoso_component_enumerator.so
-- Installing: /var/lib/adu/extensions/sources/libmicrosoft_delta_download_handler.so
-- Set runtime path of "/var/lib/adu/extensions/sources/libmicrosoft_delta_download_handler.so" to ""
-- Installing: /var/lib/adu/extensions/sources/libmicrosoft_apt_1.so
-- Set runtime path of "/var/lib/adu/extensions/sources/libmicrosoft_apt_1.so" to ""
-- Installing: /var/lib/adu/extensions/sources/libmicrosoft_script_1.so
-- Set runtime path of "/var/lib/adu/extensions/sources/libmicrosoft_script_1.so" to ""
-- Installing: /var/lib/adu/extensions/sources/libmicrosoft_simulator_1.so
-- Set runtime path of "/var/lib/adu/extensions/sources/libmicrosoft_simulator_1.so" to ""
-- Installing: /var/lib/adu/extensions/sources/libmicrosoft_swupdate_2.so
-- Set runtime path of "/var/lib/adu/extensions/sources/libmicrosoft_swupdate_2.so" to ""
-- Installing: /var/lib/adu/extensions/sources/libmicrosoft_steps_1.so
-- Set runtime path of "/var/lib/adu/extensions/sources/libmicrosoft_steps_1.so" to ""

[AndreRicardo-Zoetis]

PR: #698