Refactor array_map and array_filter #102
Conversation
| return in_array('pug', $engines); | ||
| })); | ||
| foreach ($extensions as $key => $engine) { | ||
| if (strpos($engine, 'pug') !== false) { |
There was a problem hiding this comment.
This is not equivalent as it searches for any pug sub-string not delimited by . separator.
| })); | ||
| foreach ($extensions as $key => $engine) { | ||
| if (strpos($engine, 'pug') !== false) { | ||
| $filteredExtensions[] = ".$key"; |
There was a problem hiding this comment.
Current code uses the value, not the key.
|
So unless some benchmark using recent PHP version, I wouldn't bet performance is a win here. Also codes before and after here are not equivalent, it might break some untested cases, the readability improvement does not sound worthy to me as a first sight. |
2 participants
This Pull Request introduces a refactoring of the
getPugEnginemethod within theServiceProvider. The primary objectives are to simplify the logic for enhanced readability and to improve overall performance.