Skip to content

Commit b962d60

Browse files
committed
- rename the "count" option to "pageSize" for the SortedSet type in Hive API
1 parent b2f1ef5 commit b962d60

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

backendless.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ declare module Backendless {
582582
minBound?: SortedSetBound,
583583
maxBound?: SortedSetBound,
584584
offset?: number,
585-
count?: number
585+
pageSize?: number
586586
reverse?: boolean,
587587
withScores?: boolean
588588
}): Promise<Array<T>>

src/hive/stores/sorted-set.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ export class SortedSetStore extends HiveStore {
228228
throw new Error('Options must be an object.')
229229
}
230230

231-
const { minScore, maxScore, minBound, maxBound, offset, count, withScores, reverse } = options
231+
const { minScore, maxScore, minBound, maxBound, offset, pageSize, withScores, reverse } = options
232232

233233
if (minScore !== undefined && (isNaN(minScore) || typeof minScore !== 'number')) {
234234
throw new Error('Minimal Score must be a number.')
@@ -250,8 +250,8 @@ export class SortedSetStore extends HiveStore {
250250
throw new Error('Offset must be a number.')
251251
}
252252

253-
if (count !== undefined && (typeof count !== 'number' || isNaN(count))) {
254-
throw new Error('Count must be a number.')
253+
if (pageSize !== undefined && (typeof pageSize !== 'number' || isNaN(pageSize))) {
254+
throw new Error('Page Size must be a number.')
255255
}
256256

257257
if (withScores !== undefined && typeof withScores !== 'boolean') {

test/tsd.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1133,7 +1133,7 @@ function testHiveStores() {
11331133
minBound: bound,
11341134
maxBound: bound,
11351135
offset: num,
1136-
count: num,
1136+
pageSize: num,
11371137
reverse: bool,
11381138
withScores: bool
11391139
})

test/unit/specs/hive/sorted-set.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1407,18 +1407,18 @@ describe('Hive - Sorted Set Store', function() {
14071407
await expect(() => store.getRangeByScore({ maxBound: () => undefined })).to.throw(errorMsg)
14081408
})
14091409

1410-
it('fails when Count is invalid', async () => {
1411-
const errorMsg = 'Count must be a number.'
1412-
1413-
await expect(() => store.getRangeByScore({ count: null })).to.throw(errorMsg)
1414-
await expect(() => store.getRangeByScore({ count: '' })).to.throw(errorMsg)
1415-
await expect(() => store.getRangeByScore({ count: 'foo' })).to.throw(errorMsg)
1416-
await expect(() => store.getRangeByScore({ count: NaN })).to.throw(errorMsg)
1417-
await expect(() => store.getRangeByScore({ count: {} })).to.throw(errorMsg)
1418-
await expect(() => store.getRangeByScore({ count: [] })).to.throw(errorMsg)
1419-
await expect(() => store.getRangeByScore({ count: true })).to.throw(errorMsg)
1420-
await expect(() => store.getRangeByScore({ count: false })).to.throw(errorMsg)
1421-
await expect(() => store.getRangeByScore({ count: () => undefined })).to.throw(errorMsg)
1410+
it('fails when PageSize is invalid', async () => {
1411+
const errorMsg = 'Page Size must be a number.'
1412+
1413+
await expect(() => store.getRangeByScore({ pageSize: null })).to.throw(errorMsg)
1414+
await expect(() => store.getRangeByScore({ pageSize: '' })).to.throw(errorMsg)
1415+
await expect(() => store.getRangeByScore({ pageSize: 'foo' })).to.throw(errorMsg)
1416+
await expect(() => store.getRangeByScore({ pageSize: NaN })).to.throw(errorMsg)
1417+
await expect(() => store.getRangeByScore({ pageSize: {} })).to.throw(errorMsg)
1418+
await expect(() => store.getRangeByScore({ pageSize: [] })).to.throw(errorMsg)
1419+
await expect(() => store.getRangeByScore({ pageSize: true })).to.throw(errorMsg)
1420+
await expect(() => store.getRangeByScore({ pageSize: false })).to.throw(errorMsg)
1421+
await expect(() => store.getRangeByScore({ pageSize: () => undefined })).to.throw(errorMsg)
14221422
})
14231423

14241424
it('fails when Offset is invalid', async () => {

0 commit comments

Comments
 (0)