Skip to content

Commit 5fb5813

Browse files
authored
SWI-5388 Fix Query Parameters for Some Endpoints (#68)
* SWI-5388 Fix Query Parameters for Some Endpoints * fix url * add one more query param
1 parent eb92454 commit 5fb5813

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

lib/application.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ Application.prototype.getSipPeers = function(query, callback){
100100
callback = query;
101101
query = {};
102102
}
103-
this.client.makeRequest("get", this.client.concatAccountPath(APPLICATION_PATH) + "/" + this.applicationId + "/associatedsippeers", function(err,res){
103+
this.client.makeRequest("get", this.client.concatAccountPath(APPLICATION_PATH) + "/" + this.applicationId + "/associatedsippeers", query, function(err,res){
104104
if(err){
105105
return callback(err);
106106
}

lib/site.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ Site.prototype.getInserviceNumbers = function(query, callback){
146146
callback = query;
147147
query = {};
148148
}
149-
this.client.makeRequest("get", this.client.concatAccountPath(SITE_PATH) + "/" + this.id + "/inserviceNumbers", function(err,res){
149+
this.client.makeRequest("get", this.client.concatAccountPath(SITE_PATH) + "/" + this.id + "/inserviceNumbers", query, function(err,res){
150150
if(err){
151151
return callback(err);
152152
}
@@ -173,7 +173,7 @@ Site.prototype.getPortIns = function(query, callback){
173173
callback = query;
174174
query = {};
175175
}
176-
this.client.makeRequest("get", this.client.concatAccountPath(SITE_PATH) + "/" + this.id + "/portins", function(err,res){
176+
this.client.makeRequest("get", this.client.concatAccountPath(SITE_PATH) + "/" + this.id + "/portins", query, function(err,res){
177177
if(err){
178178
return callback(err);
179179
}
@@ -187,7 +187,7 @@ Site.prototype.getTotalTns = function(query, callback){
187187
callback = query;
188188
query = {};
189189
}
190-
this.client.makeRequest("get", this.client.concatAccountPath(SITE_PATH) + "/" + this.id + "/totaltns", function(err,res){
190+
this.client.makeRequest("get", this.client.concatAccountPath(SITE_PATH) + "/" + this.id + "/totaltns", query, function(err,res){
191191
if(err){
192192
return callback(err);
193193
}

test/site.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,11 @@ describe("Site", function(){
258258
});
259259
describe("#getInserviceNumbers", function(done){
260260
it("should get a list of inservice numbers", function(done){
261-
helper.nock().get("/accounts/FakeAccountId/sites/1/inserviceNumbers").reply(200, helper.xml.inServiceNumbers, {"Content-Type": "application/xml"});
261+
helper.nock().get("/accounts/FakeAccountId/sites/1/inserviceNumbers?page=1&size=100").reply(200, helper.xml.inServiceNumbers, {"Content-Type": "application/xml"});
262262
var site = new Site();
263263
site.id = "1";
264264
site.client = helper.createClient();
265-
site.getInserviceNumbers({}, function(err,res){
265+
site.getInserviceNumbers({page: 1, size: 100}, function(err,res){
266266
if(err){
267267
return done(err);
268268
}

0 commit comments

Comments
 (0)