a few more shellcheck fixes and I think we are done.

Author: Ira Abramov

themes/metal/metal.theme.bash

@@ -62,11 +62,13 @@ function virtualenv_prompt {
 
 # Rename tab
 function tabname {
+	# shellcheck disable=SC2059
 	printf "\e]1;$1\a"
 }
 
 # Rename window
 function winname {
+	# shellcheck disable=SC2059
 	printf "\e]2;$1\a"
 }
 

themes/modern-time/modern-time.theme.bash

@@ -13,7 +13,7 @@ SCM_GIT_CHAR="${bold_green?}±${normal?}"
 SCM_SVN_CHAR="${bold_cyan?}⑆${normal?}"
 SCM_HG_CHAR="${bold_red?}☿${normal?}"
 
-case $TERM in
+case ${TERM} in
 	xterm*)
 		TITLEBAR="\[\033]0;\w\007\]"
 		;;
@@ -36,6 +36,7 @@ modern_current_time_prompt() {
 
 prompt() {
 	SCM_PROMPT_FORMAT='[%s][%s]'
+	# shellcheck disable=SC2181
 	if [ $? -ne 0 ]; then
 		# Yes, the indenting on these is weird, but it has to be like
 		# this otherwise it won't display properly.

themes/parrot/parrot.theme.bash

@@ -28,6 +28,7 @@ function prompt() {
 	fi
 
 	if [ "$color_prompt" = yes ]; then
+		# shellcheck disable=SC2028
 		PS1="\[\033[0;31m\]\342\224\214\342\224\200\$([[ \$? != 0 ]] && echo \"[\[\033[0;31m\]\342\234\227\[\033[0;37m\]]\342\224\200\")[$(if [[ ${EUID} == 0 ]]; then echo '\[\033[01;31m\]root\[\033[01;33m\]@\[\033[01;96m\]\h'; else echo '\[\033[0;39m\]\u\[\033[01;33m\]@\[\033[01;96m\]\h'; fi)\[\033[0;31m\]]\342\224\200[\[\033[0;32m\]\w\[\033[0;31m\]]\n\[\033[0;31m\]\342\224\224\342\224\200\342\224\200\342\225\274 \[\033[0m\]\[\e[01;33m\]$(parse_git_branch) $\[\e[0m\] "
 
 	else

themes/powerline-plain/powerline-plain.base.bash

@@ -6,6 +6,7 @@
 function __powerline_left_segment {
 	local OLD_IFS="${IFS}"
 	IFS="|"
+	# shellcheck disable=SC2206
 	local params=($1)
 	IFS="${OLD_IFS}"
 	local pad_before_segment=" "

themes/powerturk/powerturk.theme.bash

@@ -32,11 +32,12 @@ LAST_STATUS_THEME_PROMPT_COLOR=52
 
 _collapsed_wd() {
 	# echo -e "\u2771\u276d\u276f"
-	echo $(pwd | perl -pe "
+	# shellcheck disable=SC2005
+	echo "$(pwd | perl -pe "
    BEGIN {
       binmode STDIN,  ':encoding(UTF-8)';
       binmode STDOUT, ':encoding(UTF-8)';
-   }; s|^$HOME|<HOME>|g; s|/([^/])[^/]*(?=/)|/\$1|g") \
+   }; s|^$HOME|<HOME>|g; s|/([^/])[^/]*(?=/)|/\$1|g")" \
 		| sed -re "s/\//  /g"
 }
 
@@ -47,22 +48,22 @@ _swd() {
 	current=""          # The section of the path we're currently working on.
 	end="${2:-${PWD}}/" # The unmodified rest of the path.
 
-	if [[ "$end" =~ "$HOME" ]]; then
+	if [[ "$end" =~ $HOME ]]; then
 		INHOME=1
-		end="${end#$HOME}" #strip /home/username from start of string
-		begin="$HOME"      #start expansion from the right spot
+		end="${end#"$HOME"}" #strip /home/username from start of string
+		begin="${HOME}"      #start expansion from the right spot
 	else
 		INHOME=0
 	fi
 
-	end="${end#/}"       # Strip the first /
-	shortenedpath="$end" # The whole path, to check the length.
+	end="${end#/}"         # Strip the first /
+	shortenedpath="${end}" # The whole path, to check the length.
 	maxlength="${1:-0}"
 
 	shopt -q nullglob && NGV="-s" || NGV="-u" # Store the value for later.
 	shopt -s nullglob                         # Without this, anything that doesn't exist in the filesystem turns into */*/*/...
 
-	while [[ "$end" ]] && ((${#shortenedpath} > maxlength)); do
+	while [[ "${end}" ]] && ((${#shortenedpath} > maxlength)); do
 		current="${end%%/*}" # everything before the first /
 		end="${end#*/}"      # everything after the first /
 
@@ -71,10 +72,10 @@ _swd() {
 
 		for ((i = ${#current} - 2; i >= 0; i--)); do
 			subcurrent="${current:0:i}"
-			matching=("$begin/$subcurrent"*)  # Array of all files that start with $subcurrent.
-			((${#matching[*]} != 1)) && break # Stop shortening if more than one file matches.
-			shortcur="$subcurrent"
-			shortcurstar="$subcurrent*"
+			matching=("${begin}/${subcurrent}"*) # Array of all files that start with $subcurrent.
+			((${#matching[*]} != 1)) && break    # Stop shortening if more than one file matches.
+			shortcur="${subcurrent}"
+			shortcurstar="${subcurrent}*"
 		done
 
 		#advance
@@ -88,6 +89,7 @@ _swd() {
 
 	# Replaces slashes with  except first occurence.
 	if [ $INHOME -eq 1 ]; then
+		# shellcheck disable=SC2088
 		echo "~/$shortenedpath" | sed "s/\///2g" # make sure it starts with ~/
 	else
 		echo "/$shortenedpath" | sed "s/\///2g" # Make sure it starts with /

themes/standard/standard.theme.bash

@@ -21,6 +21,7 @@ case $TERM in
 esac
 
 function prompt_command() {
+	# shellcheck disable=SC2016
 	PROMPT='${green?}\u${normal?}@${green?}\h${normal?}:${blue?}\w${normal?}${red?}$(prompt_char)$(git_prompt_info)${normal?}\$ '
 }
 

themes/zitron/zitron.theme.bash

@@ -20,7 +20,7 @@ function prompt_command() {
 	# user:host:pwd git-branch(*)$
 	# for example:
 	# noqqe:deathstar:themes master*$
-	PS1="${no_color}\u:$(hostname)${normal?}:${bold_yellow?}\W/${normal?} $(git_prompt_info)${reset_color?}$ "
+	PS1="${no_color?}\u:$(hostname)${normal?}:${bold_yellow?}\W/${normal?} $(git_prompt_info)${reset_color?}$ "
 }
 
 safe_append_prompt_command prompt_command