Skip to content

Commit 7e40051

Browse files
Ira Abramovclaude
andcommitted
Fix SC2155 violations in theme files
Separate local variable declarations from command substitution assignments to avoid masking return values, per shellcheck SC2155. Modified files: - themes/mbriggs/mbriggs.theme.bash (2 fixes) - themes/powerline-plain/powerline-plain.base.bash (1 fix) - themes/sirup/sirup.theme.bash (2 fixes) - themes/slick/slick.theme.bash (2 fixes) - themes/zork/zork.theme.bash (2 fixes) Total: 9 SC2155 violations fixed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 178cc80 commit 7e40051

File tree

5 files changed

+18
-9
lines changed

5 files changed

+18
-9
lines changed

themes/mbriggs/mbriggs.theme.bash

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,13 @@ function git_short_sha() {
2121

2222
function prompt() {
2323
local return_status=""
24-
local ruby="${red?}$(ruby_version_prompt)${reset_color?}"
24+
local ruby
25+
ruby="${red?}$(ruby_version_prompt)${reset_color?}"
2526
local user_host="${green?}\h${reset_color?}"
2627
local current_path="\w"
2728
local n_commands="\!"
28-
local git_branch="$(git_short_sha)$(scm_prompt_info)"
29+
local git_branch
30+
git_branch="$(git_short_sha)$(scm_prompt_info)"
2931
local prompt_symbol='λ'
3032
local open='('
3133
local close=')'

themes/powerline-plain/powerline-plain.base.bash

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ function __powerline_prompt_command {
4242

4343
## left prompt ##
4444
for segment in $POWERLINE_PROMPT; do
45-
local info="$(__powerline_${segment}_prompt)"
45+
local info
46+
info="$(__powerline_${segment}_prompt)"
4647
[[ -n "${info}" ]] && __powerline_left_segment "${info}"
4748
done
4849

themes/sirup/sirup.theme.bash

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@
55
GIT_PS1_SHOWDIRTYSTATE="enabled"
66

77
function rvm_version_prompt {
8-
local gemset=$(echo $GEM_HOME | awk -F'@' '{print $2}')
8+
local gemset
9+
gemset=$(echo $GEM_HOME | awk -F'@' '{print $2}')
910

1011
[ "$gemset" != "" ] && gemset="@$gemset"
11-
local version=$(echo $MY_RUBY_HOME | awk -F'-' '{print $2}')
12+
local version
13+
version=$(echo $MY_RUBY_HOME | awk -F'-' '{print $2}')
1214

1315
[ "$version" == "1.9.2" ] && version=""
1416

themes/slick/slick.theme.bash

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@ esac
2525
PS3=">> "
2626

2727
__my_rvm_ruby_version() {
28-
local gemset=$(echo $GEM_HOME | awk -F'@' '{print $2}')
28+
local gemset
29+
gemset=$(echo $GEM_HOME | awk -F'@' '{print $2}')
2930
[ "$gemset" != "" ] && gemset="@$gemset"
30-
local version=$(echo $MY_RUBY_HOME | awk -F'-' '{print $2}')
31+
local version
32+
version=$(echo $MY_RUBY_HOME | awk -F'-' '{print $2}')
3133
local full="$version$gemset"
3234
[ "$full" != "" ] && echo "[$full]"
3335
}

themes/zork/zork.theme.bash

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,11 @@ esac
2525
PS3=">> "
2626

2727
__my_rvm_ruby_version() {
28-
local gemset=$(echo $GEM_HOME | awk -F'@' '{print $2}')
28+
local gemset
29+
gemset=$(echo $GEM_HOME | awk -F'@' '{print $2}')
2930
[ "$gemset" != "" ] && gemset="@$gemset"
30-
local version=$(echo $MY_RUBY_HOME | awk -F'-' '{print $2}')
31+
local version
32+
version=$(echo $MY_RUBY_HOME | awk -F'-' '{print $2}')
3133
local full="$version$gemset"
3234
[ "$full" != "" ] && echo "[$full]"
3335
}

0 commit comments

Comments
 (0)