Add bash 4+ version check to pack plugin (#2358)

* Add bash 3.3+ version check to pack plugin

The pack plugin uses associative arrays (declare -A) which require
bash 4.0+, but has existing checks for bash > 3 on lines 162 and 230.
Add early version check to disable and return if bash < 3.3.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* Add plugin disable calls to version checks in history-eternal and percol

Both plugins already had bash version checks with early returns, but
didn't explicitly disable themselves. Now they call _disable-plugin
before returning to ensure consistent plugin state.

- history-eternal: requires bash 4.3+ for unlimited history
- percol: requires bash 4.0+ for bind -x functionality

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* Standardize return codes and log messages for version checks

Changed both plugins to return 0 instead of 1/nothing and added
consistent log messages explaining why the plugin is being disabled:

- history-eternal: return 0 with "Disabling history-eternal plugin" message
- percol: return 0 with "Disabling percol plugin" message

This provides clearer feedback to users and consistent exit codes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* add version checks on install and init

* Update bash_it.sh

Co-authored-by: Koichi Murase <[email protected]>

* By the Book

* correct version check

---------

Co-authored-by: Ira Abramov <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Koichi Murase <[email protected]>

Author: 4 people

bash_it.sh

@@ -1,7 +1,14 @@
 #!/usr/bin/env bash
 # shellcheck source-path=SCRIPTDIR/lib source-path=SCRIPTDIR/scripts
 # shellcheck disable=SC2034
-#
+
+# Requires bash 3.2+ to install and run
+# Skip loading if bash version is too old
+if [[ "${BASH_VERSINFO[0]-}" -lt 3 ]] || [[ "${BASH_VERSINFO[0]-}" -eq 3 && "${BASH_VERSINFO[1]}" -lt 2 ]]; then
+	echo "sorry, but the minimum version of BASH supported by bash_it is 3.2, consider upgrading?" >&2
+	return 1
+fi
+
 # Initialize Bash It
 BASH_IT_LOG_PREFIX="core: main: "
 : "${BASH_IT:=${BASH_SOURCE%/*}}"

install.sh

@@ -1,6 +1,13 @@
 #!/usr/bin/env bash
 # bash-it installer
 
+# Requires bash 3.2+ to install and run
+# Skip loading if bash version is too old
+if [[ "${BASH_VERSINFO[0]-}" -lt 3 ]] || [[ "${BASH_VERSINFO[0]-}" -eq 3 && "${BASH_VERSINFO[1]}" -lt 2 ]]; then
+	echo "sorry, but the minimum version of BASH supported by bash_it is 3.2, consider upgrading?" >&2
+	return 1
+fi
+
 # Show how to use this installer
 function _bash-it-install-help() {
 	echo -e "\n$0 : Install bash-it"

plugins/available/history-eternal.plugin.bash

@@ -4,7 +4,9 @@ url "https://github.com/Bash-it/bash-it"
 
 if [[ ${BASH_VERSINFO[0]} -lt 4 ]] || [[ ${BASH_VERSINFO[0]} -eq 4 && ${BASH_VERSINFO[1]} -lt 3 ]]; then
 	_log_warning "Bash version 4.3 introduced the 'unlimited' history size capability."
-	return 1
+	_log_warning "Disabling history-eternal plugin (current version: $BASH_VERSION)"
+	_disable-plugin history-eternal
+	return 0
 fi
 
 # Modify history sizes before changing location to avoid unintentionally

plugins/available/pack.plugin.bash

@@ -1,6 +1,13 @@
 # shellcheck shell=bash
 # bash completion for pack                                 -*- shell-script -*-
 
+# Requires bash 4+ for associative arrays
+# Skip loading if bash version is too old
+if [[ "${BASH_VERSINFO[0]}" -lt 4 ]]; then
+	_disable-plugin pack
+	return 0
+fi
+
 cite about-plugin
 about-plugin 'CNB pack cli aliases'
 url "https://buildpacks.io/"

plugins/available/percol.plugin.bash

@@ -18,8 +18,9 @@ _command_exists percol || return
 
 if [[ ${BASH_VERSINFO[0]} -lt 4 ]]; then
 	_log_warning "You have to upgrade Bash to Bash v4.x to use the 'percol' plugin."
-	_log_warning "Your current Bash version is $BASH_VERSION."
-	return
+	_log_warning "Disabling percol plugin (current version: $BASH_VERSION)"
+	_disable-plugin percol
+	return 0
 fi
 
 function _replace_by_history() {