Skip to content

Commit 27c0d69

Browse files
authored
Merge pull request #100 from BeAPI/issue/99
Issue/99
2 parents 276bbd6 + eaf76ab commit 27c0d69

File tree

1 file changed

+18
-9
lines changed

1 file changed

+18
-9
lines changed

Diff for: inc/services/acf.php

+18-9
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ public function init() {
9494
*
9595
* $this->acf_add_options_page( [
9696
* 'page_title' => __( 'Theme Options', 'framework-textdomain' ),
97+
* 'menu_slug' => 'theme-options',
9798
* 'parent_slug' => 'themes.php',
9899
* ] );
99100
*
@@ -104,18 +105,22 @@ public function init() {
104105
}
105106

106107
/**
107-
* @param $parameters
108+
* Add Option Page
108109
*
109110
* @return bool
111+
*
112+
* @param $parameters
113+
*
110114
*/
111115
public function acf_add_options_page( $parameters ) {
112-
/**
113-
* Add Option Page
114-
*/
115116
if ( ! function_exists( 'acf_add_options_page' ) ) {
116117
return false;
117118
}
118119

120+
if ( ! isset( $parameters['menu_slug'] ) ) {
121+
throw new InvalidArgumentException( 'You must specify menu slug for ACF options page.' );
122+
}
123+
119124
return acf_add_options_page( $parameters );
120125

121126
}
@@ -147,18 +152,22 @@ public function get_files() {
147152
}
148153

149154
/**
150-
* @param $parameters
155+
* Add options Subpage
151156
*
152157
* @return bool
158+
*
159+
* @param $parameters
160+
*
153161
*/
154162
public function acf_add_options_sub_page( $parameters ) {
155-
/**
156-
* Add Option Subpage
157-
*/
158163
if ( ! function_exists( 'acf_add_options_sub_page' ) ) {
159164
return false;
160165
}
161166

167+
if ( ! isset( $parameters['menu_slug'] ) ) {
168+
throw new InvalidArgumentException( 'You must specify menu slug for ACF options page.' );
169+
}
170+
162171
return acf_add_options_sub_page( $parameters );
163172
}
164-
}
173+
}

0 commit comments

Comments
 (0)