Fixes expand issue with JObject key Azure#2751 (Azure#2769)

Author: BernieWhite

docs/CHANGELOG-v1.md

@@ -41,6 +41,9 @@ What's changed since pre-release v1.35.0-B0030:
 - General improvements:
   - Quality updates to rule documentation by @BernieWhite.
     [#2570](https://github.com/Azure/PSRule.Rules.Azure/issues/2570)
+- Bug fixes:
+  - Fixed failed to expand JObject value with invalid key by @BernieWhite.
+    [#2751](https://github.com/Azure/PSRule.Rules.Azure/issues/2751)
 
 ## v1.35.0-B0030 (pre-release)
 

src/PSRule.Rules.Azure/Data/Template/Mocks.cs

@@ -318,6 +318,7 @@ public virtual JToken GetValue(TypePrimitive type)
 
             public virtual JToken GetValue(object key)
             {
+                key = GetBaseObject(key);
                 var result = base[key];
                 if (result == null)
                 {
@@ -511,5 +512,19 @@ private static bool TryExpandId(JObject o)
             }
             return false;
         }
+
+        /// <summary>
+        /// Unwrap the base object from a JToken.
+        /// </summary>
+        private static object GetBaseObject(object o)
+        {
+            if (o is JToken t_string && t_string.Type == JTokenType.String)
+                return t_string.Value<string>();
+
+            if (o is JToken t_int && t_int.Type == JTokenType.Integer)
+                return t_int.Value<int>();
+
+            return o;
+        }
     }
 }

src/PSRule.Rules.Azure/Data/Template/TemplateVisitor.cs

@@ -11,6 +11,7 @@
 using PSRule.Rules.Azure.Configuration;
 using PSRule.Rules.Azure.Pipeline;
 using PSRule.Rules.Azure.Resources;
+using static PSRule.Rules.Azure.Data.Template.Mock;
 
 namespace PSRule.Rules.Azure.Data.Template
 {
@@ -910,7 +911,7 @@ public LazyOutput(TemplateContext context, string name, JObject value)
             public object GetValue()
             {
                 ResolveProperty(_Context, _Value, PROPERTY_VALUE);
-                return _Value;
+                return new MockObject(_Value);
             }
         }
 

tests/PSRule.Rules.Azure.Tests/PSRule.Rules.Azure.Tests.csproj

@@ -236,6 +236,9 @@
     <None Update="Tests.Bicep.34.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Update="Tests.Bicep.35.json">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
     <None Update="Tests.Bicep.4.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

tests/PSRule.Rules.Azure.Tests/TemplateVisitorTests.cs

@@ -13,6 +13,9 @@
 
 namespace PSRule.Rules.Azure
 {
+    /// <summary>
+    /// This class tests the functionality of the <see cref="TemplateVisitor"/> class that is used to expand resources from an ARM template/ Bicep file.
+    /// </summary>
     public sealed class TemplateVisitorTests
     {
         [Fact]
@@ -1092,6 +1095,15 @@ public void UnionMockWithArray()
             Assert.Equal("Microsoft.KeyVault/vaults/accessPolicies", actual["type"].Value<string>());
         }
 
+        /// <summary>
+        /// Test case for https://github.com/Azure/PSRule.Rules.Azure/issues/2751.
+        /// </summary>
+        [Fact]
+        public void Index_into_mock_output_object()
+        {
+            var resources = ProcessTemplate(GetSourcePath("Tests.Bicep.35.json"), null, out _);
+        }
+
         #region Helper methods
 
         private static string GetSourcePath(string fileName)

tests/PSRule.Rules.Azure.Tests/Tests.Bicep.35.bicep

@@ -0,0 +1,31 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+// Test case for https://github.com/Azure/PSRule.Rules.Azure/issues/2751.
+
+var roles = ['Reader']
+
+module script 'br/public:avm/res/resources/deployment-script:0.1.2' = {
+  name: 'script'
+  params: {
+    kind: 'AzurePowerShell'
+    name: toLower('ds-001')
+    retentionInterval: 'PT1H'
+    azPowerShellVersion: '9.7'
+    arguments: ''
+    scriptContent: '''
+      
+    '''
+  }
+}
+
+module other './Tests.Bicep.35.child.bicep' = [
+  for role in roles: {
+    name: role
+    params: {
+      value: script.outputs.outputs[role]
+    }
+  }
+]
+
+output other string = other[0].outputs.value

tests/PSRule.Rules.Azure.Tests/Tests.Bicep.35.child.bicep

@@ -0,0 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
+param value string
+
+output value string = value