Skip to content

Commit 634a5e8

Browse files
committed
qt: fix support for Wayland on linux
Unfortunately the Comments before the `-extra-plugins` without line-break delimiter made it a separate command. The `-` in Makefile means `extra-plugins` is executed ignoring errors. This combination made CI pass without Wayland plugins actually being deployed. Fixes #3229.
1 parent 0e65f73 commit 634a5e8

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
- Reduced support for BitBox01
55
- Fix a bug that would prevent the app to perform firmware upgrade when offline.
66

7+
# 4.47.1
8+
- Linux: fix support for Wayland
9+
710
# 4.47.0
811
- Bundle BitBox02 firmware version v9.22.0
912
- Fix long transaction notes to show fully on multiple lines when necessary

backend/update.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const updateFileURL = "https://bitboxapp.shiftcrypto.io/desktop.json"
2727

2828
var (
2929
// Version of the backend as displayed to the user.
30-
Version = semver.NewSemVer(4, 47, 0)
30+
Version = semver.NewSemVer(4, 47, 1)
3131
)
3232

3333
// UpdateFile is retrieved from the server.

frontends/qt/Makefile

+5-5
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ linux:
3030
mv build/BitBox build/linux-tmp
3131
cp build/assets.rcc build/linux-tmp/
3232
cp server/libserver.so build/linux-tmp
33+
# Add Wayland libs so the app can run natively on Wayland too.
34+
# The linuxdeployqt maintainer unfortunately refuses to support it automatically: https://github.com/probonopd/linuxdeployqt/issues/189
35+
# The list of related plugins was found by: `find $(qmake -query QT_INSTALL_PLUGINS) | grep wayland`
3336
cd build/linux-tmp && /opt/linuxdeployqt-continuous-x86_64.AppImage BitBox \
3437
-bundle-non-qt-libs \
3538
-unsupported-allow-new-glibc \
36-
# Add Wayland libs so the app can run natively on Wayland too.
37-
# The linuxdeployqt maintainer unfortunately refuses to support it automatically: https://github.com/probonopd/linuxdeployqt/issues/189
38-
# The list of related plugins was found by: `find $(qmake -query QT_INSTALL_PLUGINS) | grep wayland`
3939
-extra-plugins=platforms/libqwayland-generic.so,platforms/libqwayland-egl.so,wayland-graphics-integration-client,wayland-decoration-client,wayland-shell-integration
4040
cp /usr/lib/x86_64-linux-gnu/nss/* build/linux-tmp/lib
4141
# See https://github.com/probonopd/linuxdeployqt/issues/554#issuecomment-1761834180
@@ -45,8 +45,8 @@ linux:
4545
cp resources/linux/usr/share/icons/hicolor/128x128/apps/bitbox.png build/linux-tmp
4646
mkdir build/tmp-deb/opt/
4747
cp -aR build/linux-tmp build/tmp-deb/opt/bitbox
48-
cd build/linux && fpm --after-install ../../resources/deb-afterinstall.sh -s dir -t deb -n bitbox -v 4.47.0 -C ../tmp-deb/
49-
cd build/linux && fpm --after-install ../../resources/deb-afterinstall.sh -s dir -t rpm -n bitbox -v 4.47.0 -C ../tmp-deb/
48+
cd build/linux && fpm --after-install ../../resources/deb-afterinstall.sh -s dir -t deb -n bitbox -v 4.47.1 -C ../tmp-deb/
49+
cd build/linux && fpm --after-install ../../resources/deb-afterinstall.sh -s dir -t rpm -n bitbox -v 4.47.1 -C ../tmp-deb/
5050
# create AppImage
5151
cd build/linux-tmp && /opt/linuxdeployqt-continuous-x86_64.AppImage BitBox -appimage -unsupported-allow-new-glibc
5252
mv build/linux-tmp/BitBoxApp-*-x86_64.AppImage build/linux/

0 commit comments

Comments
 (0)