bitbox01: remove legacy registeredChanged event

Was only used in bitbox01.jsx, and there it was actually useless since
DeviceSwitch is fed the devices list already (from app.tsx using the
new style event) to decide to mount/unmount the
component.

Author: benma

backend/backend.go

@@ -115,12 +115,6 @@ const (
 	eventNewTxs event = "new-txs"
 )
 
-type backendEvent struct {
-	Type string      `json:"type"`
-	Data string      `json:"data"`
-	Meta interface{} `json:"meta"`
-}
-
 type deviceEvent struct {
 	DeviceID string `json:"deviceID"`
 	Type     string `json:"type"`
@@ -813,15 +807,6 @@ func (backend *Backend) Register(theDevice device.Interface) error {
 		return err
 	}
 
-	// Old-school
-	select {
-	case backend.events <- backendEvent{
-		Type: "devices",
-		Data: "registeredChanged",
-	}:
-	default:
-	}
-	// New-school
 	backend.Notify(observable.Event{
 		Subject: "devices/registered",
 		Action:  action.Reload,
@@ -843,9 +828,6 @@ func (backend *Backend) Deregister(deviceID string) {
 		delete(backend.devices, deviceID)
 		backend.DeregisterKeystore()
 
-		// Old-school
-		backend.events <- backendEvent{Type: "devices", Data: "registeredChanged"}
-		// New-school
 		backend.Notify(observable.Event{
 			Subject: "devices/registered",
 			Action:  action.Reload,

frontends/web/src/routes/device/bitbox01/bitbox01.jsx

@@ -51,19 +51,14 @@ class Device extends Component {
 
   state = {
     firmwareVersion: null,
-    deviceRegistered: false,
     deviceStatus: '',
     goal: '',
     success: null,
   };
 
   componentDidMount() {
-    this.onDevicesRegisteredChanged();
     this.onDeviceStatusChanged();
     this.unsubscribe = apiWebsocket(({ type, data, deviceID }) => {
-      if (type === 'devices' && data === 'registeredChanged') {
-        this.onDevicesRegisteredChanged();
-      }
       if (type === 'device' && data === 'statusChanged' && deviceID === this.getDeviceID()) {
         this.onDeviceStatusChanged();
       }
@@ -76,40 +71,15 @@ class Device extends Component {
     }
   }
 
-  componentDidUpdate(prevProps) {
-    if (this.props.deviceID !== prevProps.deviceID) {
-      this.onDevicesRegisteredChanged();
-    }
-  }
-
-  onDevicesRegisteredChanged = () => {
-    apiGet('devices/registered').then(devices => {
-      const deviceIDs = Object.keys(devices);
-      const deviceRegistered = deviceIDs.includes(this.getDeviceID());
-
-      this.setState({
-        deviceRegistered,
-        deviceStatus: null
-      }, () => {
-        // only if deviceRegistered or softwarekeystore
-        if (this.state.deviceRegistered) {
-          this.onDeviceStatusChanged();
-        }
-      });
-    });
-  };
-
   onDeviceStatusChanged = () => {
-    if (this.state.deviceRegistered) {
-      apiGet('devices/' + this.props.deviceID + '/status').then(deviceStatus => {
-        if (['seeded', 'initialized'].includes(deviceStatus)) {
-          this.context.setSidebarStatus('');
-        } else {
-          this.context.setSidebarStatus('forceHidden');
-        }
-        this.setState({ deviceStatus });
-      });
-    }
+    apiGet('devices/' + this.props.deviceID + '/status').then(deviceStatus => {
+      if (['seeded', 'initialized'].includes(deviceStatus)) {
+        this.context.setSidebarStatus('');
+      } else {
+        this.context.setSidebarStatus('forceHidden');
+      }
+      this.setState({ deviceStatus });
+    });
   };
 
   getDeviceID() {
@@ -137,12 +107,11 @@ class Device extends Component {
       deviceID,
     } = this.props;
     const {
-      deviceRegistered,
       deviceStatus,
       goal,
       success,
     } = this.state;
-    if (!deviceRegistered || !deviceStatus) {
+    if (!deviceStatus) {
       return null;
     }
     if (success) {