bitcoin: enable message signing on testnet and regtest #1378
+120
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Beerosagos I added his to send_message.py for easier manual testing as discussed. |
Beerosagos
approved these changes
Mar 25, 2025
|
|
||
| def sign_testnet() -> None: | ||
| keypath = [49 + HARDENED, 1 + HARDENED, 0 + HARDENED, 0, 0] | ||
| script_config = bitbox02.btc.BTCScriptConfig( |
There was a problem hiding this comment.
nit: since you use the same script_config both times maybe you can directly include it in the sign function?
There was a problem hiding this comment.
I think I'll leave it, as the script config is tightly coupled to the keypath, so being able to modify one but not the other locally seems off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1376