Use golangci-lint to run govet

Author: flimzy

.golangci.toml

@@ -8,6 +8,7 @@ format = "colored-line-number"
 disable-all = true
 enable = [
     "gofumpt",
+    "govet",
 ]
 
 [issues]

circle.yml

@@ -72,14 +72,6 @@ jobs:
     executor: gopherjs
     steps:
     - setup_and_install_gopherjs
-    - run:
-        name: Check go vet
-        command: |
-          set -e
-          # Go package in root directory.
-          go vet .
-          # All subdirectories except "doc", "tests", "node*".
-          for d in */; do echo ./$d...; done | grep -v ./doc | grep -v ./tests | grep -v ./node | xargs go vet
     - run:
         name: Check natives build tags
         command: diff -u <(echo -n) <(go list ./compiler/natives/src/...) # All those packages should have // +build js.

tests/goroutine_test.go

@@ -73,7 +73,7 @@ func testPanic2(t *testing.T) {
 	time.Sleep(0)
 	checkI(t, 4)
 	panic(7)
-	checkI(t, -3)
+	checkI(t, -3) //nolint:govet // Unreachable code is intentional for panic test
 }
 
 func TestPanicAdvanced(t *testing.T) {

tests/misc_test.go

@@ -536,7 +536,7 @@ func TestTrivialSwitch(t *testing.T) {
 		}
 		return
 	}
-	t.Fail()
+	t.Fail() //nolint:govet // unreachable code intentional for test
 }
 
 func TestTupleFnReturnImplicitCast(t *testing.T) {