Skip to content

Commit e0fa65a

Browse files
committed
[avalanche] Fix a race in abc_p2p_avalanche_contender_voting
Summary: Looking at the log while checking the isfinalrpc is racy and not redundant. Test Plan: ./test/functional/test_runner.py abc_p2p_avalanche_contender_voting.py Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D17284
1 parent 7768cfe commit e0fa65a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/functional/abc_p2p_avalanche_contender_voting.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,7 @@ def has_finalized_tip(tip_expected):
124124

125125
# Finalize a block so we promote the contender cache with every block
126126
tip = node.getbestblockhash()
127-
with node.assert_debug_log([f"Avalanche finalized block {tip}"]):
128-
self.wait_until(lambda: has_finalized_tip(tip))
127+
self.wait_until(lambda: has_finalized_tip(tip))
129128
assert_equal(node.getbestblockhash(), tip)
130129

131130
# Now trigger building the whole cache for a block

0 commit comments

Comments
 (0)