Skip to content

[Bug] Should unsubscribe event handlers #603

@Jimmys20

Description

@Jimmys20

Event handlers in BlazoredModal are never unsubscribed. Should probably be done in DisposeAsync.

((ModalService)CascadedModalService).OnModalInstanceAdded += Update;
((ModalService)CascadedModalService).OnModalCloseRequested += CloseInstance;
NavigationManager.LocationChanged += CancelModals;
async ValueTask IAsyncDisposable.DisposeAsync()
{
    ((ModalService)CascadedModalService).OnModalInstanceAdded -= Update;
    ((ModalService)CascadedModalService).OnModalCloseRequested -= CloseInstance;
    NavigationManager.LocationChanged -= CancelModals;

    ...
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingTriageIssue needs to be triaged

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions