Gordian Server breaks with Bitcoin 23.0

[shannona]

It looks like the main problem is that MacOS binary URL changed from the expected:

https://bitcoincore.org/bin/bitcoin-core-23.0/bitcoin-23.0-osx64.tar.gz

To one of:

https://bitcoincore.org/bin/bitcoin-core-23.0/bitcoin-23.0-arm64-apple-darwin.tar.gz
https://bitcoincore.org/bin/bitcoin-core-23.0/bitcoin-23.0-x86_64-apple-darwin.tar.gz

(There are also DMGs, but I presume the tar.gz is still preferred.)

Download now needs to occur from:

bitcoin-${processedVersion}-`uname -m`-apple.darwin.tar.gz

The uname -m command from the command line can provide the architecture. The uname() command in Swift can do the same, per this [see the currently 4th answer], but it'll tell you arm64 if it's running in Rosetta, which Gordian Server will be, so we presumably want to get the command-line answer to get them Bitcoin proper running efficiently on the appropriate architecture. (Hopefully that won't also be running in Rosetta since it's a script, but we won't know until we test.)

So, my suggestion is:

1. Move the final composition of the download URL from GordianServer-macOS/Helpers/UrlRequest.swift to GordianServer-MacOS/Scripts/Standup.command to take advantage of the uname -m command line option.
2. Adjust the URL for apple-darwin instead of osx.

[ChristopherA]

/cc @Fonta1n3 : is something you can take care of? After all, Gordian Server is largely used with your Fully Noded customers.

[Fonta1n3]

/cc @Fonta1n3 : is something you can take care of? After all, Gordian Server is largely used with your Fully Noded customers.

It's an easy fix, but will break again if they change the url. Happy to do it.

[ChristopherA]

That would be great. Thanks!