You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It makes no semantic sense to compare values of different types. Rather, PartialOrd could return None if self.ty != other.ty.
Yes -- I tried this, but we then lose Ord on Word (which maaybe makes sense, you can compare them numerically though you have to decide the relationship between 0u4 and 0u16 etc), and on Node and on Policy... so it's far-reaching.
I think the right approach would be to change Policy to implement Ord manually in alphabetical order (we do this in rust-miniscript now; it was a PITA to implement) and then we can drop Ord on the smaller types.
It makes no semantic sense to compare values of different types. Rather,
PartialOrd
could returnNone
ifself.ty != other.ty
.(see #266)
We have to see how much work it is, but making the API more semantically consistent seems worth some effort.
The text was updated successfully, but these errors were encountered: