fuzz: add regression test for value encoding #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should let us compile multiple versions of simplicity-sys in the same dependency tree.
apoelstra
force-pushed
the
2025-03--fix-windows
branch
from
19661c5 to
10fc3c6
Compare
|
Ok, I tweaked the fuzz test and now I think I have found a regression. |
| @@ -798,7 +798,7 @@ impl Iterator for CompactBitsIter<'_> { | |||
|
|
|||
| fn next(&mut self) -> Option<Self::Item> { | |||
| while let Some(value) = self.stack.pop() { | |||
| if value.is_unit() { | |||
| if value.ty.bit_width() == 0 { | |||
|
I broke my local CI with this -- I think because 0.3.0 is the same version in the git repo and on crates.io, so it struggles to include both of them. Let's do #270 first, which includes a version bump to avoid this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the branch name this does not fix the Windows build. It adds a regression test for value encoding, which after running 250 CPU-hours locally has failed to find any regressions. But I did find some unrelated issues, mainly around memory allocations.
Fixes #279
Fixes #278