Merge #113: Mark const methods

c0c62db chore: Mark methods as const (Christian Lewe)
509a855 fix: Clippy (Christian Lewe)

Pull request description:

  Mark some key methods as const.

ACKs for top commit:
  apoelstra:
    ACK c0c62db; successfully ran local tests

Tree-SHA512: e854f3a5cbc4d842fab58db7afc5ab84231f8d5263fc2ed78f4dc6c1570558b71a6535fab372d9175844df19c0b60f751c9b5b0135f3f83568c1d07c908d5311

Author: apoelstra

src/num.rs

@@ -225,14 +225,14 @@ impl U256 {
     /// Create a 256-bit unsigned integer from a byte array.
     ///
     /// The byte array is in Big Endian order.
-    pub fn from_byte_array(bytes: [u8; 32]) -> Self {
+    pub const fn from_byte_array(bytes: [u8; 32]) -> Self {
         Self(bytes)
     }
 
     /// Convert the integer to a byte array.
     ///
     /// The byte array is in Big Endian order.
-    pub fn to_byte_array(self) -> [u8; 32] {
+    pub const fn to_byte_array(self) -> [u8; 32] {
         self.0
     }
 }

src/value.rs

@@ -155,7 +155,7 @@ impl UIntValue {
             let mut byte = 0u8;
             for _ in 0..8 {
                 let bit = padded_bits.next().unwrap();
-                byte = byte << 1 | if bit == '1' { 1 } else { 0 };
+                byte = (byte << 1) | if bit == '1' { 1 } else { 0 };
             }
             bytes.push(byte);
         }
@@ -607,12 +607,12 @@ impl From<UIntValue> for Value {
 
 impl Value {
     /// Access the inner structure of the value.
-    pub fn inner(&self) -> &ValueInner {
+    pub const fn inner(&self) -> &ValueInner {
         &self.inner
     }
 
     /// Access the type of the value.
-    pub fn ty(&self) -> &ResolvedType {
+    pub const fn ty(&self) -> &ResolvedType {
         &self.ty
     }