Trim line endings properly on Windows for LineIter

Author: BooleanCat

internal/assert/assert.go

@@ -3,34 +3,46 @@ package assert
 import "testing"
 
 func Equal[T comparable](t *testing.T, a, b T) {
+	t.Helper()
+
 	if a != b {
 		t.Errorf("expected `%v` to equal `%v`", a, b)
 	}
 }
 
 func True(t *testing.T, b bool) {
+	t.Helper()
+
 	if !b {
 		t.Error("expected `false` to be `true`")
 	}
 }
 
 func False(t *testing.T, b bool) {
+	t.Helper()
+
 	if b {
 		t.Error("expected `true` to be `false`")
 	}
 }
 
 func Nil(t *testing.T, v interface{}) {
+	t.Helper()
+
 	Equal(t, v, nil)
 }
 
 func NotNil(t *testing.T, v interface{}) {
+	t.Helper()
+
 	if v == nil {
 		t.Error("expected `nil` not to equal `nil`")
 	}
 }
 
 func SliceEqual[T comparable](t *testing.T, a, b []T) {
+	t.Helper()
+
 	if len(a) != len(b) {
 		t.Errorf("expected `%v` to equal `%v` but lengths differ", a, b)
 		return
@@ -44,6 +56,8 @@ func SliceEqual[T comparable](t *testing.T, a, b []T) {
 }
 
 func Empty[T any](t *testing.T, items []T) {
+	t.Helper()
+
 	if len(items) != 0 {
 		t.Errorf("expected `%v` to be empty", items)
 	}

iter/lines.go

@@ -2,6 +2,7 @@ package iter
 
 import (
 	"bufio"
+	"bytes"
 	"fmt"
 	"io"
 
@@ -44,7 +45,7 @@ func (iter *LinesIter) Next() option.Option[result.Result[[]byte]] {
 		return option.Some(result.Err[[]byte](fmt.Errorf(`read line: %w`, err)))
 	}
 
-	return option.Some(result.Ok(content[:len(content)-1]))
+	return option.Some(result.Ok(bytes.TrimRight(content, "\r\n")))
 }
 
 var _ Iterator[result.Result[[]byte]] = new(LinesIter)