Skip to content

Commit af2d872

Browse files
authored
feat: expose better error messages out of the runtime so folks can better understand isseus (i/e can plumb cancel messages more correctly) (#2679)
1 parent 2bb5751 commit af2d872

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

engine/baml-runtime/src/types/response.rs

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,17 +134,30 @@ impl FunctionResult {
134134
crate::internal::llm_client::ErrorCode::Other(2) => {
135135
Err(anyhow::anyhow!(err.message.clone()))
136136
}
137-
_ => {
138-
Err(anyhow::anyhow!(crate::errors::ExposedError::ClientHttpError {
137+
_ => Err(anyhow::anyhow!(
138+
crate::errors::ExposedError::ClientHttpError {
139139
client_name: err.client.clone(),
140140
message: err.message.clone(),
141141
status_code: err.code.clone(),
142142
detailed_message: err.message.clone(),
143-
}))
144-
}
143+
}
144+
)),
145145
}
146146
}
147-
_ => Err(anyhow::anyhow!("No result from baml - Please report this error to our team with BAML_LOG=info enabled so we can improve this error message"))
147+
LLMResponse::UserFailure(message) => {
148+
Err(anyhow::anyhow!("User Failure: {message}.\nPlease report this error to our team with BAML_LOG=info enabled so we can catch this error earlier and improve your development experience."))
149+
}
150+
LLMResponse::InternalFailure(message) => {
151+
Err(anyhow::anyhow!("Internal Failure: {message}.\nThis should not happen - please report this error to our team with BAML_LOG=info enabled so we can catch this error earlier and improve your development experience."))
152+
}
153+
LLMResponse::Cancelled(message) => {
154+
Err(anyhow::anyhow!(crate::errors::ExposedError::AbortError {
155+
detailed_message: message.clone(),
156+
}))
157+
}
158+
LLMResponse::Success(_) => {
159+
Err(anyhow::anyhow!("This should never happen - Please report this error to our team with BAML_LOG=info enabled so we can improve this error message"))
160+
}
148161
}
149162
})
150163
}

0 commit comments

Comments
 (0)