Disable (temporarily?) the sectionArray mixin because it is currently broken

MeeniMc · MeeniMc · commit e5c1e8f056ab · 2021-11-21T17:28:39.000-05:00
Signed-off-by: MeeniMc &lt;68366846+MeeniMc@users.noreply.github.com&gt;
diff --git a/src/main/java/me/jellysquid/mods/hydrogen/mixin/chunk/MixinWorldChunk.java b/src/main/java/me/jellysquid/mods/hydrogen/mixin/chunk/MixinWorldChunk.java
@@ -44,10 +44,13 @@ private void reinit(World world, ChunkPos pos,
 
         // Upgrading a ProtoChunk to a WorldChunk might result in empty sections being copied over
         // These simply waste memory, and the WorldChunk will return air blocks for any absent section without issue.
+
+        /* DISABLED because many places in WorldChunk do sectionArray[i].empty() without testing for null first
         for (int i = 0; i < sectionArray.length; i++) {
             if (sectionArray[i].isEmpty()) {
                 sectionArray[i] = null;
             }
         }
+         */
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -44,10 +44,13 @@ private void reinit(World world, ChunkPos pos,`
`44`	`44`
`45`	`45`	`// Upgrading a ProtoChunk to a WorldChunk might result in empty sections being copied over`
`46`	`46`	`// These simply waste memory, and the WorldChunk will return air blocks for any absent section without issue.`
	`47`	`+`
	`48`	`+ /* DISABLED because many places in WorldChunk do sectionArray[i].empty() without testing for null first`
`47`	`49`	`for (int i = 0; i < sectionArray.length; i++) {`
`48`	`50`	`if (sectionArray[i].isEmpty()) {`
`49`	`51`	`sectionArray[i] = null;`
`50`	`52`	`}`
`51`	`53`	`}`
	`54`	`+ */`
`52`	`55`	`}`
`53`	`56`	`}`