Merge pull request #301 from CampingOn/refactor/#205-reservation

refactor: 스케줄러로 예약완료인 상태만 체크

Author: silverzoo

src/main/java/site/campingon/campingon/reservation/service/ReservationStatusUpdate.java

@@ -31,7 +31,7 @@ public void updateStatusToNotCancelable() {
         List<Reservation> reservations = reservationRepository.findByCheckin(targetTime);
 
         reservations.stream()
-                .filter(reservation -> reservation.getStatus() != ReservationStatus.NOTCANCELABLE)
+                .filter(reservation -> reservation.getStatus() != ReservationStatus.RESERVED)
                 .forEach(reservation -> reservation.changeStatus(ReservationStatus.NOTCANCELABLE));
 
         reservationRepository.saveAll(reservations);
@@ -43,14 +43,14 @@ public void updateStatusToNotCancelable() {
     @Scheduled(cron = "0 0 15 * * ?")
     public void updateStatusToCompleted() {
         LocalDateTime now = LocalDateTime.now(ZoneId.of("Asia/Seoul"));
-        LocalDateTime targetDate = now.toLocalDate().atTime(15, 0);
-
-        List<Reservation> reservations = reservationRepository.findByCheckin(targetDate);
-        for (Reservation reservation : reservations) {
-            if (reservation.getStatus() != ReservationStatus.COMPLETED) {
-                reservation.changeStatus(ReservationStatus.COMPLETED);
-            }
-        }
+        LocalDateTime targetTime = now.toLocalDate().atTime(15, 0);
+
+        List<Reservation> reservations = reservationRepository.findByCheckin(targetTime);
+
+        reservations.stream()
+                .filter(reservation -> reservation.getStatus() == ReservationStatus.RESERVED)
+                .forEach(reservation -> reservation.changeStatus(ReservationStatus.COMPLETED));
+
         reservationRepository.saveAll(reservations);
 
         log.debug("체크인완료 업데이트 스케줄러가 실행되었습니다.");

src/test/java/site/campingon/campingon/reservation/service/ReservationServiceTest.java

@@ -103,6 +103,7 @@ void setUp() {
                 .campResponseDto(mockCampDto)
                 .campAddrResponseDto(mockCampAddrDto)
                 .build();
+
     }
 
     @Test