Skip to content

Commit 5e1aaf7

Browse files
SuperQSuperQ
authored
Fixup mixin linting (prometheus#646)
Update various items to make the mixin linter happy. Signed-off-by: SuperQ <[email protected]>
1 parent d66a380 commit 5e1aaf7

File tree

3 files changed

+41
-11
lines changed

3 files changed

+41
-11
lines changed

‎mysqld-mixin/alerts/galera.yaml

+10-10
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ groups:
1616
severity: warning
1717
annotations:
1818
description: '{{$labels.job}} on {{$labels.instance}} is not ready.'
19-
summary: Galera cluster node not ready
19+
summary: Galera cluster node not ready.
2020
- alert: MySQLGaleraOutOfSync
2121
expr: (mysql_global_status_wsrep_local_state != 4 and mysql_global_variables_wsrep_desync
2222
== 0)
@@ -26,7 +26,7 @@ groups:
2626
annotations:
2727
description: '{{$labels.job}} on {{$labels.instance}} is not in sync ({{$value}}
2828
!= 4).'
29-
summary: Galera cluster node out of sync
29+
summary: Galera cluster node out of sync.
3030
- alert: MySQLGaleraDonorFallingBehind
3131
expr: (mysql_global_status_wsrep_local_state == 2 and mysql_global_status_wsrep_local_recv_queue
3232
> 100)
@@ -36,39 +36,39 @@ groups:
3636
annotations:
3737
description: '{{$labels.job}} on {{$labels.instance}} is a donor (hotbackup)
3838
and is falling behind (queue size {{$value}}).'
39-
summary: xtradb cluster donor node falling behind
39+
summary: XtraDB cluster donor node falling behind.
4040
- alert: MySQLReplicationNotRunning
4141
expr: mysql_slave_status_slave_io_running == 0 or mysql_slave_status_slave_sql_running
4242
== 0
4343
for: 2m
4444
labels:
4545
severity: critical
4646
annotations:
47-
description: Slave replication (IO or SQL) has been down for more than 2 minutes.
48-
summary: Slave replication is not running
47+
description: "Replication on {{$labels.instance}} (IO or SQL) has been down for more than 2 minutes."
48+
summary: Replication is not running.
4949
- alert: MySQLReplicationLag
5050
expr: (instance:mysql_slave_lag_seconds > 30) and on(instance) (predict_linear(instance:mysql_slave_lag_seconds[5m],
5151
60 * 2) > 0)
5252
for: 1m
5353
labels:
5454
severity: critical
5555
annotations:
56-
description: The mysql slave replication has fallen behind and is not recovering
57-
summary: MySQL slave replication is lagging
56+
description: "Replication on {{$labels.instance}} has fallen behind and is not recovering."
57+
summary: MySQL slave replication is lagging.
5858
- alert: MySQLHeartbeatLag
5959
expr: (instance:mysql_heartbeat_lag_seconds > 30) and on(instance) (predict_linear(instance:mysql_heartbeat_lag_seconds[5m],
6060
60 * 2) > 0)
6161
for: 1m
6262
labels:
6363
severity: critical
6464
annotations:
65-
description: The mysql heartbeat is lagging and is not recovering
66-
summary: MySQL heartbeat is lagging
65+
description: "The heartbeat is lagging on {{$labels.instance}} and is not recovering."
66+
summary: MySQL heartbeat is lagging.
6767
- alert: MySQLInnoDBLogWaits
6868
expr: rate(mysql_global_status_innodb_log_waits[15m]) > 10
6969
labels:
7070
severity: warning
7171
annotations:
7272
description: The innodb logs are waiting for disk at a rate of {{$value}} /
7373
second
74-
summary: MySQL innodb log writes stalling
74+
summary: MySQL innodb log writes stalling.

‎mysqld-mixin/alerts/general.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ groups:
88
severity: critical
99
annotations:
1010
description: 'MySQL {{$labels.job}} on {{$labels.instance}} is not up.'
11-
summary: MySQL not up
11+
summary: MySQL not up.

‎mysqld-mixin/dashboards/mysql-overview.json

+30
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@
308308
"error": false,
309309
"fieldConfig": {
310310
"defaults": {
311+
"unit": "short",
311312
"custom": {}
312313
},
313314
"overrides": []
@@ -459,6 +460,7 @@
459460
"error": false,
460461
"fieldConfig": {
461462
"defaults": {
463+
"unit": "short",
462464
"custom": {}
463465
},
464466
"overrides": []
@@ -627,6 +629,7 @@
627629
"error": false,
628630
"fieldConfig": {
629631
"defaults": {
632+
"unit": "short",
630633
"custom": {}
631634
},
632635
"overrides": []
@@ -743,6 +746,7 @@
743746
"error": false,
744747
"fieldConfig": {
745748
"defaults": {
749+
"unit": "short",
746750
"custom": {}
747751
},
748752
"overrides": []
@@ -903,6 +907,7 @@
903907
"error": false,
904908
"fieldConfig": {
905909
"defaults": {
910+
"unit": "short",
906911
"custom": {}
907912
},
908913
"overrides": []
@@ -989,6 +994,7 @@
989994
"timeRegions": [],
990995
"timeShift": null,
991996
"title": "MySQL Temporary Objects",
997+
"description": "MySQL Temporary Objects",
992998
"tooltip": {
993999
"msResolution": false,
9941000
"shared": true,
@@ -1036,6 +1042,7 @@
10361042
"error": false,
10371043
"fieldConfig": {
10381044
"defaults": {
1045+
"unit": "short",
10391046
"custom": {}
10401047
},
10411048
"overrides": []
@@ -1215,6 +1222,7 @@
12151222
"error": false,
12161223
"fieldConfig": {
12171224
"defaults": {
1225+
"unit": "short",
12181226
"custom": {}
12191227
},
12201228
"overrides": []
@@ -1365,6 +1373,7 @@
13651373
"error": false,
13661374
"fieldConfig": {
13671375
"defaults": {
1376+
"unit": "short",
13681377
"custom": {}
13691378
},
13701379
"overrides": []
@@ -1491,6 +1500,7 @@
14911500
"error": false,
14921501
"fieldConfig": {
14931502
"defaults": {
1503+
"unit": "short",
14941504
"custom": {}
14951505
},
14961506
"overrides": []
@@ -1616,6 +1626,7 @@
16161626
"error": false,
16171627
"fieldConfig": {
16181628
"defaults": {
1629+
"unit": "short",
16191630
"custom": {}
16201631
},
16211632
"overrides": []
@@ -1754,6 +1765,7 @@
17541765
"error": false,
17551766
"fieldConfig": {
17561767
"defaults": {
1768+
"unit": "short",
17571769
"custom": {}
17581770
},
17591771
"overrides": []
@@ -1892,6 +1904,7 @@
18921904
"error": false,
18931905
"fieldConfig": {
18941906
"defaults": {
1907+
"unit": "short",
18951908
"custom": {}
18961909
},
18971910
"overrides": []
@@ -2092,6 +2105,7 @@
20922105
"error": false,
20932106
"fieldConfig": {
20942107
"defaults": {
2108+
"unit": "short",
20952109
"custom": {}
20962110
},
20972111
"overrides": []
@@ -2210,6 +2224,7 @@
22102224
"error": false,
22112225
"fieldConfig": {
22122226
"defaults": {
2227+
"unit": "short",
22132228
"custom": {}
22142229
},
22152230
"overrides": []
@@ -2320,6 +2335,7 @@
23202335
"error": false,
23212336
"fieldConfig": {
23222337
"defaults": {
2338+
"unit": "short",
23232339
"custom": {}
23242340
},
23252341
"overrides": []
@@ -2383,6 +2399,7 @@
23832399
"timeRegions": [],
23842400
"timeShift": null,
23852401
"title": "MySQL Transaction Handlers",
2402+
"description": "MySQL Transaction Handlers",
23862403
"tooltip": {
23872404
"msResolution": false,
23882405
"shared": true,
@@ -2429,6 +2446,7 @@
24292446
"error": false,
24302447
"fieldConfig": {
24312448
"defaults": {
2449+
"unit": "short",
24322450
"custom": {}
24332451
},
24342452
"overrides": []
@@ -2493,6 +2511,7 @@
24932511
"timeRegions": [],
24942512
"timeShift": null,
24952513
"title": "Process States",
2514+
"description": "Process States",
24962515
"tooltip": {
24972516
"msResolution": false,
24982517
"shared": true,
@@ -2539,6 +2558,7 @@
25392558
"error": false,
25402559
"fieldConfig": {
25412560
"defaults": {
2561+
"unit": "short",
25422562
"custom": {}
25432563
},
25442564
"overrides": []
@@ -2602,6 +2622,7 @@
26022622
"timeRegions": [],
26032623
"timeShift": null,
26042624
"title": "Top Process States Hourly",
2625+
"description": "Top Process States Hourly",
26052626
"tooltip": {
26062627
"msResolution": false,
26072628
"shared": true,
@@ -2664,6 +2685,7 @@
26642685
"error": false,
26652686
"fieldConfig": {
26662687
"defaults": {
2688+
"unit": "short",
26672689
"custom": {}
26682690
},
26692691
"overrides": []
@@ -2787,6 +2809,7 @@
27872809
"error": false,
27882810
"fieldConfig": {
27892811
"defaults": {
2812+
"unit": "short",
27902813
"custom": {}
27912814
},
27922815
"overrides": []
@@ -2964,6 +2987,7 @@
29642987
"error": false,
29652988
"fieldConfig": {
29662989
"defaults": {
2990+
"unit": "short",
29672991
"custom": {}
29682992
},
29692993
"overrides": []
@@ -3026,6 +3050,7 @@
30263050
"timeRegions": [],
30273051
"timeShift": null,
30283052
"title": "MySQL File Openings",
3053+
"description": "MySQL File Openings",
30293054
"tooltip": {
30303055
"msResolution": false,
30313056
"shared": true,
@@ -3072,6 +3097,7 @@
30723097
"error": false,
30733098
"fieldConfig": {
30743099
"defaults": {
3100+
"unit": "short",
30753101
"custom": {}
30763102
},
30773103
"overrides": []
@@ -3154,6 +3180,7 @@
31543180
"timeRegions": [],
31553181
"timeShift": null,
31563182
"title": "MySQL Open Files",
3183+
"description": "MySQL Open Files",
31573184
"tooltip": {
31583185
"msResolution": false,
31593186
"shared": true,
@@ -3216,6 +3243,7 @@
32163243
"error": false,
32173244
"fieldConfig": {
32183245
"defaults": {
3246+
"unit": "short",
32193247
"custom": {}
32203248
},
32213249
"overrides": []
@@ -3372,6 +3400,7 @@
33723400
"error": false,
33733401
"fieldConfig": {
33743402
"defaults": {
3403+
"unit": "short",
33753404
"custom": {}
33763405
},
33773406
"overrides": []
@@ -3515,6 +3544,7 @@
35153544
"error": false,
35163545
"fieldConfig": {
35173546
"defaults": {
3547+
"unit": "short",
35183548
"custom": {}
35193549
},
35203550
"overrides": []

0 commit comments

Comments
 (0)