Skip to content

Commit 79f8c5b

Browse files
authored
[Metrics] Scope unregister_vllm_metrics() to strictly "vllm:" metrics (vllm-project#42331)
`unregister_vllm_metrics()` currently uses "vllm" in `collector._name` to decide which collectors to remove from the Prometheus registry, removing every even metrics registered by other subsystems or downstream extensions like "vllm_omni:" Signed-off-by: vraiti <vraiti@redhat.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
1 parent f81daf8 commit 79f8c5b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

vllm/v1/metrics/prometheus.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def unregister_vllm_metrics():
6464
registry = REGISTRY
6565
# Unregister any existing vLLM collectors
6666
for collector in list(registry._collector_to_names):
67-
if hasattr(collector, "_name") and "vllm" in collector._name:
67+
if hasattr(collector, "_name") and collector._name.startswith("vllm:"):
6868
registry.unregister(collector)
6969

7070

0 commit comments

Comments
 (0)