If url_to_postid can't find the post ID of a URL, the Impacts metabox does some weird things.

[benlk]

Consider a situation where a custom taxonomy is used as a permalink structure, but the rewrite rules used by url_to_postid() cause url_to_postid to not find any post ID.

In this situation, when creating a MORI impact via Dashboard > MORI > Add New Impact, pasting the post URL into the editor and saving the Impact saves the URL in the impact post meta, but this fact is not presented to the user.

The reason that the saved URL is not presented to the user is because when the metabox callback https://github.com/Chalkbeat/MORI/blob/master/chalkbeat-MORI/metaboxes/impact-metabox.php#L17-L26 loads the impact metabox template https://github.com/Chalkbeat/MORI/blob/master/chalkbeat-MORI/metaboxes/templates/submit-url.php, the template displays the "empty" view when url_to_postid($url['path']) == 0. This means that the user believes that no impact association has been created, which is probably true (I haven't checked).

Here's a few recommended fixes:

• don't save the URL unless url_to_postid can find a post ID
• display an error to the user if url_to_postid fails
• if you're going to keep the URL saved, display it in that box, but with a warning that the post ID was not found and the impact association was not created

[cjhickerson]

Thanks for the report. I've move this issue into our Asana to take a look at this week.

[benlk]

If you need a plugin to recreate the url_to_postid issue, try using the usen-regions-taxonomy plugin at commit bf844797497783efd0d8cc4d705b0504d82ebc9e in INN/umbrella-energynewsnetwork@bf84479#diff-39d8471f7d701508567265d5fca88f4f — the current master branch of that repository has a fix for url-to_postid described at INN/umbrella-energynewsnetwork#39. You'll need to set the permalink structure to /%region%/%postname%/.