fix(server): sync commitSizeLimit default with CollectionSession.trlimit

application.py unconditionally overwrote session.trlimit with the config
value, which defaulted to 0 (no limit), silently negating the trlimit=5000
class default added in 89be20c. Reference CollectionSession.trlimit directly
so the default cannot silently drift if the class default ever changes,
and add a regression test.

Author: anderslindho

server/demo.conf

@@ -48,9 +48,8 @@
 # Doesn't effect IOC clients
 #commitInterval = 5.0
 
-# Maximum size before committing updates
-# The default is 0 (which is no limit)
-#commitSizeLimit = 0
+# Maximum records per commit. Default is 5000; set to 0 for no limit.
+#commitSizeLimit = 5000
 
 # Maximum concurrent "active" clients
 # to allow.

server/recceiver/application.py

@@ -15,7 +15,7 @@
 from . import metrics
 from .announcer import Announcer, SharedUDP
 from .processors import ProcessorController
-from .recast import CastFactory
+from .recast import CastFactory, CollectionSession
 
 log = logging.getLogger(__name__)
 
@@ -46,7 +46,7 @@ def __init__(self, config):
         self.annperiod = float(config.get("announceInterval", "15.0"))
         self.tcptimeout = float(config.get("tcptimeout", "15.0"))
         self.commitperiod = float(config.get("commitInterval", "5.0"))
-        self.commitSizeLimit = int(config.get("commitSizeLimit", "0"))
+        self.commitSizeLimit = int(config.get("commitSizeLimit", str(CollectionSession.trlimit)))
         self.maxActive = int(config.get("maxActive", "20"))
         self.bind, _sep, portn = config.get("bind", "").strip().partition(":")
         self.addrlist = []

server/tests/unit/test_application.py

@@ -0,0 +1,16 @@
+from recceiver.application import RecService
+from recceiver.recast import CollectionSession
+
+
+class TestRecServiceConfig:
+    def test_commit_size_limit_defaults_to_class_default(self):
+        svc = RecService({})
+        assert svc.commitSizeLimit == CollectionSession.trlimit
+
+    def test_commit_size_limit_reads_from_config(self):
+        svc = RecService({"commitSizeLimit": "100"})
+        assert svc.commitSizeLimit == 100
+
+    def test_commit_size_limit_zero_disables_splitting(self):
+        svc = RecService({"commitSizeLimit": "0"})
+        assert svc.commitSizeLimit == 0