Skip to content

Commit c26e65f

Browse files
authored
Remove redundant ts.isArray checks (roblox-ts#1872)
* Update addOneIfArrayType.ts * Update getAccessorForBindingType.ts
1 parent 69b80ae commit c26e65f

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/TSTransformer/util/addOneIfArrayType.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { isArrayType, isDefinitelyType, isUndefinedType } from "TSTransformer/ut
55
import ts from "typescript";
66

77
export function addOneIfArrayType(state: TransformState, type: ts.Type, expression: luau.Expression) {
8-
if (ts.isArray(type) || isDefinitelyType(type, isArrayType(state), isUndefinedType)) {
8+
if (isDefinitelyType(type, isArrayType(state), isUndefinedType)) {
99
return offset(expression, 1);
1010
} else {
1111
return expression;

src/TSTransformer/util/binding/getAccessorForBindingType.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ const iterAccessor: BindingAccessor = (state, parentId, index, idStack, isOmitte
141141
};
142142

143143
export function getAccessorForBindingType(state: TransformState, node: ts.Node, type: ts.Type): BindingAccessor {
144-
if (ts.isArray(type) || isDefinitelyType(type, isArrayType(state))) {
144+
if (isDefinitelyType(type, isArrayType(state))) {
145145
return arrayAccessor;
146146
} else if (isDefinitelyType(type, isStringType)) {
147147
return stringAccessor;

0 commit comments

Comments
 (0)