Skip to content

Commit 0ef06ec

Browse files
committed
Update URL field returned by OEmbed test
* Twitter has changed the url it returns from the live API
1 parent 0519a8d commit 0ef06ec

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

Diff for: json/statuses/oembed.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"cache_age":"3153600000","url":"https:\/\/twitter.com\/twitter\/statuses\/99530515043983360","height":null,"provider_url":"https:\/\/twitter.com","provider_name":"Twitter","author_name":"Twitter","version":"1.0","author_url":"https:\/\/twitter.com\/twitter","type":"rich","html":"\u003Cblockquote class=\"twitter-tweet\"\u003E\u003Cp lang=\"en\" dir=\"ltr\"\u003ECool! \u201C\u003Ca href=\"https:\/\/twitter.com\/tw1tt3rart\"\u003E@tw1tt3rart\u003C\/a\u003E: \u003Ca href=\"https:\/\/twitter.com\/hashtag\/TWITTERART?src=hash\"\u003E#TWITTERART\u003C\/a\u003E \u2571\u2571\u2571\u2571\u2571\u2571\u2571\u2571 \u2571\u2571\u256D\u2501\u2501\u2501\u2501\u256E\u2571\u2571\u256D\u2501\u2501\u2501\u2501\u256E \u2571\u2571\u2503\u2587\u2506\u2506\u2587\u2503\u2571\u256D\u252B\u24E6\u24D4\u24D4\u24DA\u2503 \u2571\u2571\u2503\u25BD\u25BD\u25BD\u25BD\u2503\u2501\u256F\u2503\u2661\u24D4\u24DD\u24D3\u2503 \u2571\u256D\u252B\u25B3\u25B3\u25B3\u25B3\u2523\u256E\u2571\u2570\u2501\u2501\u2501\u2501\u256F \u2571\u2503\u2503\u2506\u2506\u2506\u2506\u2503\u2503\u2571\u2571\u2571\u2571\u2571\u2571 \u2571\u2517\u252B\u2506\u250F\u2513\u2506\u2523\u251B\u2571\u2571\u2571\u2571\u2571\u201D\u003C\/p\u003E— Twitter (@twitter) \u003Ca href=\"https:\/\/twitter.com\/twitter\/status\/99530515043983360\"\u003EAugust 5, 2011\u003C\/a\u003E\u003C\/blockquote\u003E\n\u003Cscript async src=\"\/\/platform.twitter.com\/widgets.js\" charset=\"utf-8\"\u003E\u003C\/script\u003E","width":550}
1+
{"url":"https:\/\/twitter.com\/twitter\/status\/99530515043983360","author_name":"Twitter","author_url":"https:\/\/twitter.com\/twitter","html":"\u003Cblockquote class=\"twitter-tweet\"\u003E\u003Cp lang=\"en\" dir=\"ltr\"\u003ECool! “\u003Ca href=\"https:\/\/twitter.com\/tw1tt3rart\"\u003E@tw1tt3rart\u003C\/a\u003E: \u003Ca href=\"https:\/\/twitter.com\/hashtag\/TWITTERART?src=hash\"\u003E#TWITTERART\u003C\/a\u003E ╱╱╱╱╱╱╱╱ ╱╱╭━━━━╮╱╱╭━━━━╮ ╱╱┃▇┆┆▇┃╱╭┫ⓦⓔⓔⓚ┃ ╱╱┃▽▽▽▽┃━╯┃♡ⓔⓝⓓ┃ ╱╭┫△△△△┣╮╱╰━━━━╯ ╱┃┃┆┆┆┆┃┃╱╱╱╱╱╱ ╱┗┫┆┏┓┆┣┛╱╱╱╱╱”\u003C\/p\u003E— Twitter (@twitter) \u003Ca href=\"https:\/\/twitter.com\/twitter\/status\/99530515043983360\"\u003EAugust 5, 2011\u003C\/a\u003E\u003C\/blockquote\u003E\n\u003Cscript async src=\"\/\/platform.twitter.com\/widgets.js\" charset=\"utf-8\"\u003E\u003C\/script\u003E","width":550,"height":null,"type":"rich","cache_age":"3153600000","provider_name":"Twitter","provider_url":"https:\/\/twitter.com","version":"1.0"}1\u2571\u201D\u003C\/p\u003E— Twitter (@twitter) \u003Ca href=\"https:\/\/twitter.com\/twitter\/status\/99530515043983360\"\u003EAugust 5, 2011\u003C\/a\u003E\u003C\/blockquote\u003E\n\u003Cscript async src=\"\/\/platform.twitter.com\/widgets.js\" charset=\"utf-8\"\u003E\u003C\/script\u003E","width":550}

Diff for: oembed.go

+5
Original file line numberDiff line numberDiff line change
@@ -68,5 +68,10 @@ func (a TwitterApi) baseUrlV1() string {
6868
if a.baseUrl == BaseUrl {
6969
return BaseUrlV1
7070
}
71+
72+
if a.baseUrl == "" {
73+
return BaseUrlV1
74+
}
75+
7176
return a.baseUrl
7277
}

Diff for: oembed_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ func TestOEmbed(t *testing.T) {
1919
}
2020

2121
if !reflect.DeepEqual(o, expectedOEmbed) {
22-
t.Errorf("Actual OEmbed differs expected:\n%+v\n Got: \n%+v\n", expectedOEmbed, o)
22+
t.Errorf("Actual OEmbed differs expected:\n%#v\n Got: \n%#v\n", expectedOEmbed, o)
2323
}
2424
}
2525

2626
var expectedOEmbed anaconda.OEmbed = anaconda.OEmbed{
2727
Cache_age: "3153600000",
28-
Url: "https://twitter.com/twitter/statuses/99530515043983360",
28+
Url: "https://twitter.com/twitter/status/99530515043983360",
2929
Height: 0,
3030
Provider_url: "https://twitter.com",
3131
Provider_name: "Twitter",

0 commit comments

Comments
 (0)