Mod Priority Reordering reverts priority number when Left Mouse Click is pressed

[PickMeNow]

Please make sure the issue is an issue with the mod manager first. If your issue is a Skyrim error/bug, I'm only interested in helping it if the mod manager is causing it.

Describe the bug
When trying to order mods for Baldur's Gate 3, I noticed the priority changes once you use left mouse click to reorder.

Ex: Last (bottom) mod priority is 300 , once it press the mouse click and move it up the priority changes to 0, Mod that is 0 (top) will have priority 300

Important: The priority is kept intact after the left mouse click is lifted, only affects the priority order visually when left mouse click is pressed !

Manager Version
Stable or Beta?

• Stable 1.3.10

Is the issue with a specific game or a general Issue?

• Only tested in BG3, I believe this is due to a previous request when the order/priority was changed.

To Reproduce
Steps to reproduce the behavior:

• Add 9 or more mods, pick the last one and try to put it in the middle only using left mouse click you will see the all numbers revert from 9 to 0, 8 to 1 , 7 to 2 etc.

Expected behavior
A clear and concise description of what you expected to happen.

• Order should be kept when left mouse click is pressed, should only decrease of increase in values of 1 when modifying the row in place. Left Mouse Click being pressed or lifted should have no effect on the mods priority number if the mod selected did not change rows.

Desktop (please complete the following information):

• ArchLinux 7.0.12-zen1-1-zen

[ChrisDKN]

Similar issue to #165

This should only happen when priority is reversed. It's a consequence of some of the hacky workarounds to make it work and should mostly be cosmetic (albeit pretty annoying)

I'm working on fixing some these things with reverse priority sorting and should have something in the next pre release build soon

[ChrisDKN]

I believe I got most of my main issues with reverse priority sorting, Fixes are in the latest release. Don't want to say I got them all since there's always some odd thing that someone finds

[PickMeNow]

Thank you for all your dedication to Amethyst Mod Manager!!!!

I tested and seems to be working like 98%, i noticed just some small hiccups, like moving mods between separators it doesn't let me put the selected mod in the last position of the separator I moved to ( with 1 click moving the mouse ) , first i need to move it to the new separator and then move manually it to the last position. ( 2 clicks + moving the mouse )

Another issue I detected not sure if its related, I loaded an load order from MO2 and the separators were 1 level higher than the mods, for example:

----- Separator 1 ----
Mod 1
Mod 2
Mod 3
---- Separator 2 ---
Mod 4
Mod 5
Mod 6
----- Separator 3 -----
Mod 7
Mod 8
Mod 9

When I import to Amethyst:

---- Separator 1 ----
---- Separator 2 ----
Mod 1
Mod 2
Mod 3
---- Separator 3 -----
Mod 4
Mod 5
Mod 6

---

Mod 7
Mod 8
Mod 9

I had to rearrange manually but with these last changes (much appreciated ones!!!) I can now completely replace BG3MM!! <3

[ChrisDKN]

The first thing I can fix, Not sure how i even missed that.

The second can't really be fixed, it would require changing how mods and separators are rendered onto the panel and also how modlist.txt is written.

The mods from an mo2 modlist.txt look like

---- Separator 2 ---
Mod 3
Mod 2
Mod 1
----- Separator 1 ----

Since Amethyst reads and writes modlist.txt bottom to top and treats mods below a separator as part of that separator, it causes the first separator to appear empty and shifted out of place. It should only affect mo2 imports though and is fairly trivial to fix by shifting separators up.