fix(module): ensure exit_json and fail_json return

Refactored the module to use `return` with `exit_json` and `fail_json` for better control flow. Added comprehensive tests for check mode behavior, covering scenarios where components are present or absent in the repository.

Author: brianveltman

plugins/modules/raw_component.py

@@ -299,14 +299,14 @@ def main():
                     'changed': False,
                     'msg': "Component already exists in repository"
                 })
-                module.exit_json(**result)
+                return module.exit_json(**result)
 
             if module.check_mode:
                 result.update({
                     'changed': True,
                     'msg': "Component would be uploaded (check mode)"
                 })
-                module.exit_json(**result)
+                return module.exit_json(**result)
 
             # Proceed with upload
             upload_url = build_upload_url(base_url, repo_name)
@@ -335,21 +335,22 @@ def main():
             })
 
             if success:
-                module.exit_json(**result)
+                return module.exit_json(**result)
         else:
             if not exists:
                 result.update({
                     'changed': False,
                     'msg': "Component does not exist in repository"
                 })
-                module.exit_json(**result)
+                return module.exit_json(**result)
 
             if module.check_mode:
                 result.update({
                     'changed': True,
                     'msg': "Component would have been deleted (if not in check mode)"
                 })
-                module.exit_json(**result)
+                return module.exit_json(**result)
+
 
             # Proceed with deletion
             if delete_component_by_id(
@@ -363,7 +364,7 @@ def main():
                     'changed': True,
                     'msg': "Component deleted successfully"
                 })
-                module.exit_json(**result)
+                return module.exit_json(**result)
             else:
                 result.update({
                     'changed': False,
@@ -376,13 +377,13 @@ def main():
             'msg': str(e),
             'error': {'type': 'component', 'details': str(e)}
         })
-        module.fail_json(**result)
+        return module.fail_json(**result)
     except Exception as e:
         result.update({
             'msg': f"An unexpected error occurred: {str(e)}",
             'error': {'type': 'unexpected', 'details': str(e)}
         })
-        module.fail_json(**result)
+        return module.fail_json(**result)
 
 
 if __name__ == '__main__':

tests/unit/plugins/modules/test_raw_component.py

@@ -358,3 +358,106 @@ def _setup_mock_module(self, tmp_path):
         mock_module.exit_json = MagicMock()
 
         return mock_module, test_file
+
+    def test_check_mode(self, tmp_path):
+        """Test check mode behavior for both present and absent states"""
+        from ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component import main
+
+        # Create a test file
+        test_file = tmp_path / "test-component.txt"
+        test_file.write_text("test content")
+
+        # Basic module parameters
+        module_params = {
+            'state': 'present',
+            'repository': 'https://nexus.example.com/repository/raw-hosted',
+            'name': 'test-component.txt',
+            'src': str(test_file),
+            'dest': '/upload/path',
+            'validate_certs': False,
+            'timeout': 30,
+            'username': 'testuser',
+            'password': 'testpass'
+        }
+
+        # Test check mode for state=present, component doesn't exist
+        mock_module = MagicMock()
+        mock_module.params = module_params.copy()
+        mock_module.check_mode = True
+
+        with patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.AnsibleModule') as mock_ansible_module, \
+            patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.get_repository_details') as mock_repo_details, \
+            patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.check_component_exists') as mock_check_exists:
+
+            mock_ansible_module.return_value = mock_module
+            mock_repo_details.return_value = ('raw', 'hosted')
+            mock_check_exists.return_value = (False, None)
+
+            main()
+
+            # Verify check mode behavior for upload
+            mock_module.exit_json.assert_called_once()
+            call_args = mock_module.exit_json.call_args[1]
+            assert call_args['changed'] is True
+            assert call_args['msg'] == "Component would be uploaded (check mode)"
+            assert not call_args['exists']
+
+        # Test check mode for state=present, component exists
+        mock_module.exit_json.reset_mock()
+        with patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.AnsibleModule') as mock_ansible_module, \
+            patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.get_repository_details') as mock_repo_details, \
+            patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.check_component_exists') as mock_check_exists:
+
+            mock_ansible_module.return_value = mock_module
+            mock_repo_details.return_value = ('raw', 'hosted')
+            mock_check_exists.return_value = (True, 'test-component-id')
+
+            main()
+
+            # Verify check mode behavior for existing component
+            mock_module.exit_json.assert_called_once()
+            call_args = mock_module.exit_json.call_args[1]
+            assert call_args['changed'] is False
+            assert call_args['msg'] == "Component already exists in repository"
+            assert call_args['exists'] is True
+            assert call_args['details']['component_id'] == 'test-component-id'
+
+        # Test check mode for state=absent, component exists
+        mock_module.params['state'] = 'absent'
+        mock_module.exit_json.reset_mock()
+        with patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.AnsibleModule') as mock_ansible_module, \
+            patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.get_repository_details') as mock_repo_details, \
+            patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.check_component_exists') as mock_check_exists:
+
+            mock_ansible_module.return_value = mock_module
+            mock_repo_details.return_value = ('raw', 'hosted')
+            mock_check_exists.return_value = (True, 'test-component-id')
+
+            main()
+
+            # Verify check mode behavior for deletion
+            mock_module.exit_json.assert_called_once()
+            call_args = mock_module.exit_json.call_args[1]
+            assert call_args['changed'] is True
+            assert call_args['msg'] == "Component would have been deleted (if not in check mode)"
+            assert call_args['exists'] is True
+            assert call_args['details']['component_id'] == 'test-component-id'
+
+        # Test check mode for state=absent, component doesn't exist
+        mock_module.exit_json.reset_mock()
+        with patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.AnsibleModule') as mock_ansible_module, \
+            patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.get_repository_details') as mock_repo_details, \
+            patch('ansible_collections.cloudkrafter.nexus.plugins.modules.raw_component.check_component_exists') as mock_check_exists:
+
+            mock_ansible_module.return_value = mock_module
+            mock_repo_details.return_value = ('raw', 'hosted')
+            mock_check_exists.return_value = (False, None)
+
+            main()
+
+            # Verify check mode behavior for non-existent component
+            mock_module.exit_json.assert_called_once()
+            call_args = mock_module.exit_json.call_args[1]
+            assert call_args['changed'] is False
+            assert call_args['msg'] == "Component does not exist in repository"
+            assert not call_args['exists']