Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ERPVP map packs #1

Open
CADBOT opened this issue Jul 9, 2023 · 6 comments
Open

Add support for ERPVP map packs #1

CADBOT opened this issue Jul 9, 2023 · 6 comments

Comments

@CADBOT
Copy link

CADBOT commented Jul 9, 2023

First off I really appreciate your assistance of the ER Linux community!

I don't know if you're familiar at all with the DEN/ERPVP scene, but competitive Elden Ring is played using a specific mod. That mod can be found here: https://www.nexusmods.com/eldenring/mods/3648?tab=description

It would be awesome if this could be added into the list of mods you can toggle on and off with this tool! I haven't been able to get it working manually yet, but could maybe help fashion a PR for it after I do get it working.

My biggest concern is all the instructions for this mod demonstrate the "new" style of mod loading (using an independent launcher and not injecting DLL's into the launch options and game directory) It also uses preview 3 of the mod engine. I don't know if my inability to get this working is due to a version error or user error. I was able to get seamless running via your original proton fork repo.

Happy to help out and provide assistance however I can. Thanks again!

@Cloudef
Copy link
Owner

Cloudef commented Jul 10, 2023

Looking at the mod page, this should work simply by enabling seamless co-op and then choosing DEN maps as modengine2 mod.

@Cloudef
Copy link
Owner

Cloudef commented Jul 10, 2023

Though you might have to rename config_denmaps_june_v1.3.toml to config_eldenring.toml. Modengine2 can do DLL loading as well nowadays, I haven't verified if it works in linux however, but that should take care of the included DEN-Maps.dll, if it does not work, you can try removing it from config_eldenring.toml and then moving the DEN-Maps.dll to the ELDEN RING/game/mods directory.

Let me know which steps (if any) worked and I can perhaps streamline it. If simply renaming toml file works, then I will add more smarter toml config detection in elden-proton which does not just assume it's always named config_eldenring.toml.

Also, I'd actually like to include some popular modengine2 mods that you could toggle, but it's not possible (at least sanely) for mods hosted in nexusmods I'm afraid.

@CADBOT
Copy link
Author

CADBOT commented Jul 10, 2023

When I was doing this manually seamless worked okay and the mod_loader.log claimed to load all the DLLs... but I got no modengine log files. What you described above combined with the tool got me close enough to get good enough logs to figure out there rest of the way. Thanks!

config_denmaps_june_v1.3.toml and to be renamed modengine.toml. Not sure why as I thought they flipped over to config_eldenring.toml, but modengine.toml worked.

I did have to copy paste the dll's into the mod folder.

The other change I had to make was take the denmaps folder will all the content and put it in the EldenRing game folder, kind of like how seamless is in there (EldenRing/Game/Seamless and EldernRing/game/denmaps).

I'll keep playing with it tonight to understand it better. Thanks!

Semi-related but have you talked to the modengine2 team about updating their work to make linux a first class citizen? It would be cool to have this stuff upstream :D

@Cloudef
Copy link
Owner

Cloudef commented Jul 10, 2023

I guess you are using the modengine-proton and not this elden-proton wrapper? I've given upstream the permission to merge the work. However since the modengine-proton needs another DLL injector to actually work, the user experience is different from regular modengine, thus would complicate the support I think. Ideally the dll injection in modengine should be fixed to work in wine, but I haven't had time to tinker that far yet.

@CADBOT
Copy link
Author

CADBOT commented Jul 11, 2023

I blew up everything and did it completely through this elden-proton wrapper.

is your other project modengine-proton? I mean this project specifically: https://github.com/Cloudef/ModEngine2/releases/tag/2.0.0.1-proton-v3

I was referring to getting regular modengine to support proton, but I think you're probably correct. The workflows and user experience probably is too radically different. It would be great if the dll injection worked with wine!

I was able to get standalone seamless working purely by launching it's executable through team, so something like that should be possible for mod engine.

Thanks again!

@Cloudef
Copy link
Owner

Cloudef commented Jul 11, 2023

All right, I'll test the mod myself later as well. Ideally these steps should work with elden proton:

  1. enable seamless co-op from dll mods page
  2. select DEN folder as modloader2 mod
  3. launch game

for 2. to work, I need to make elden-proton to search for other .toml files if the usual config_eldenring.toml is not found in that folder, and also make sure modengine's additional DLL injection works, if the DLL injection does not work, as a quick workaround I can parse the TOML and copy the dlls to the mods folder temporarily.

Ideally I do want to fix modengine2 too so it works the same way on linux as on windows, it most likely requires the replacement of MS's detours library (this would make it compile on mingw as well).

I just remembered, that I've done this kind of work for xiloader before as well here Cloudef/xiloader-wine@238aaf3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants