Only admin user can launch the weather plugin ? Why results are displayed on all sessions ?

[ludetie]

@Cod-e-Codes
These are suggestions :

I installed the weather plugin via admin session and restarted the server.

When the admin session launch the :weather command , all members see results, It would be great to be able to choose if the admin wants to share this information or not.
It would be great also to give the possibility to non admin users to launch this command and to share results or not.

Long life to Marchat ! 👍

[Cod-e-Codes]

Hey @ludetie! Thank you for testing and for opening this issue.

I'll investigate further on the weather plugin with admin commands.
The weather plugin uses wttr.in internally, and you can switch the language and other output options if you’d like to see what features work:
https://github.com/chubin/wttr.in

Plugins in marchat are designed to be hot-loadable. You can install, enable, disable, and uninstall them without restarting the server.
It’s recommended to disable a plugin before uninstalling it, as some files may still be in use. Please let me know any other issues and suggestions you may have.

Thank you!

[Cod-e-Codes]

@ludetie I’ve fixed the issue in commit eef279e. Plugin commands now correctly respect their AdminOnly flag:

• Admin-only commands still require admin privileges
• Non-admin users can now run plugin commands marked with AdminOnly: false

I'm still investigating the private vs broadcasted output.

[ludetie]

Hello @Cod-e-Codes
I installed the v0.9.0-beta.3 and still cannot launch the weather plugin from a non-admin session :

The plugin.json file :

How to configure "AdminOnly=false" ,
In the plugin.json file we find a "admin_only" parameter , it's the same thing ?

Thank you for your work.

[Cod-e-Codes]

Hey @ludetie,

I’ve retested on v0.9.0-beta.3 and confirmed that :weather and :forecast both work for non-admin users when admin_only is set to false.

Please verify that your server binary shows v0.9.0-beta.3 in the banner. If it does, try uninstalling and reinstalling the weather plugin.

Let me know if the issue persists after that.

[Cod-e-Codes]

If you’d like to test the weather plugin directly, you can connect to the demo server at:

wss://marchat.Cod-e-Codes.com/ws

Just run the client as a non-admin (no encryption needed) and try :weather or :forecast.

[ludetie]

I checked :

And reinstall the plugin:

But there is no change.

Maybe it's because the server runs under root account ?
Maybe it needs to have a variable to determine the path of the plugin store ?

[Cod-e-Codes]

Thanks for the update. Running as root shouldn’t inherently prevent non-admin users from running the weather plugin, since access is determined by MARCHAT_USERS.

Since it works on my side in both encrypted and unencrypted sessions, the issue may be related to caching or the plugin path. A few things to try:

• Disable the weather plugin before uninstalling it (:disable weather).
• Uninstall (:uninstall weather), refresh the plugin store (:refresh), and reinstall it (:install weather).
• If that doesn't work, double-check that it is enabled (:enable weather).
• You could also try setting MARCHAT_CONFIG_DIR to a dedicated folder and moving any config/profile files there.
• Optionally, set MARCHAT_PLUGIN_REGISTRY_URL to https://raw.githubusercontent.com/Cod-e-Codes/marchat-plugins/main/registry.json.

Could you also confirm whether :weather works for an admin user on your setup? That will help determine if the issue is specific to non-admin sessions.

[ludetie]

I disabled the plugin and uninstalled it

I changed the config folder ; the command line to launch the server is now :

sudo MARCHAT_CONFIG_DIR=/home/ludeti/Apps/marchat/config MARCHAT_TLS_CERT_FILE=/etc/letsencrypt/live/ludeti.mooo.com/fullchain.pem MARCHAT_TLS_KEY_FILE=/etc/letsencrypt/live/ludeti.mooo.com/privkey.pem MARCHAT_USERS=bob MARCHAT_ADMIN_KEY=xxxxxxxxxxxxxxxxx MARCHAT_MAX_FILE_MB=500 MARCHAT_PORT=9090 MARCHAT_DB_PATH=/home/ludeti/Apps/marchat/chat.db MARCHAT_JWT_SECRET=xxxxxxxxxxxxxxxxxx /home/ludeti/Apps/marchat/marchat-server-linux-amd64 --admin-panel --web-panel

Then, I installed the plugin , it appears in the new configured folder but It did not fix the issue.

The :weather command works under admin session and I tried to enable it again.

[Cod-e-Codes]

Thanks for all the details and testing. I’m currently on vacation and won’t be able to dig into this further immediately. Once I’m back home, I can take a closer look and investigate why non-admin sessions aren’t able to run the weather plugin in your setup.

Appreciate your patience!

[ludetie]

Ok, enjoy your vacation !

[Cod-e-Codes]

Thank you! We'll get this fixed soon!

[Cod-e-Codes]

Hey @ludetie, I found the issue.

Non-admin users’ plugin commands weren’t reaching the server in encrypted sessions because the client only sent : commands as admin commands (unencrypted). I fixed it so all : commands are now sent unencrypted, letting the server handle permissions properly.

This allows non-admin users to run :weather (and similar) without breaking admin-only checks.
Fixed in commit b850f12 and will be included in the next build. 👍