Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the warnings from TS diagnostics during the tests #271

Open
joojis opened this issue Dec 12, 2018 · 0 comments
Open

Resolve the warnings from TS diagnostics during the tests #271

joojis opened this issue Dec 12, 2018 · 0 comments
Labels
test

Comments

@joojis
Copy link
Contributor

joojis commented Dec 12, 2018 •
edited
Loading

Currently, it doesn't make the tests fail because of warnOnly flag in the jest.config.js.

    "ts-jest": {
      diagnostics: {
        warnOnly: true
      }
    }

Warning example

ts-jest[ts-compiler] (WARN) TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
src/key/__test__/MemoryKeyStore.spec.ts:60:46 - error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'.
@joojis joojis added the test label Dec 12, 2018
@joojis joojis changed the title Resolve TS diagnostics warnings during the tests Resolve warnings from TS diagnostics during the tests Dec 12, 2018
@joojis joojis changed the title Resolve warnings from TS diagnostics during the tests Resolve the warnings from TS diagnostics during the tests Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joojis