New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheme #517

Closed

majecty opened this issue Oct 5, 2020 · 1 comment

Assignees

Contributor

majecty commented Oct 5, 2020 •

edited

Loading

The current scheme code has some flaws.

It has an Engine as a field. Scheme is a configuration. It can have some configuration for the engine, but must not have engine directly.
It is creating a genesis header. Since the module can configuration their genesis state, we are updating the genesis block's state root after the scheme creates the header. https://github.com/CodeChain-io/foundry/blob/master/core/src/client/client.rs#L106

majecty self-assigned this

Contributor Author

majecty commented Dec 22, 2020

The scheme file is removed as a process of #538

majecty closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment