Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark tests #4

Open
kseo opened this issue Aug 4, 2018 · 3 comments
Open

Add benchmark tests #4

kseo opened this issue Aug 4, 2018 · 3 comments
Assignees
@somniumism
Labels
good first issue Good for newcomers

Comments

@kseo
Copy link
Member

kseo commented Aug 4, 2018

We need benchmark tests before working on performance optimizations such as CodeChain-io/foundry#45 and CodeChain-io/foundry#46.
@kseo kseo assigned sgkim126 and unassigned foriequal0 Sep 30, 2019
@kseo kseo pinned this issue Jan 2, 2020
@kseo kseo unpinned this issue Jan 2, 2020
@kseo kseo transferred this issue from CodeChain-io/codechain Jan 2, 2020
@sgkim126 sgkim126 transferred this issue from CodeChain-io/foundry Jan 3, 2020
@sgkim126 sgkim126 changed the title util/merkle needs benchmark tests Add benchmark tests Jan 3, 2020
@sgkim126 sgkim126 added the good first issue Good for newcomers label Jan 3, 2020
@sgkim126 sgkim126 assigned somniumism and unassigned sgkim126 Jan 3, 2020
@somniumism somniumism pinned this issue Jan 6, 2020
@somniumism somniumism unpinned this issue Jan 6, 2020
@somniumism
Copy link
Contributor

somniumism commented Jan 10, 2020 •
edited
Loading

@sgkim126 @kseo Four benchmarks already exist in /benches; bench_read_multiple, bench_read_single, bench_write_multiple and bench_write_single.
Could you explain to me what additional work I need to do?

@sgkim126
Copy link

You can add any benchmark tests that can show the performance of #2 and #3 has increased.

@somniumism
Copy link
Contributor

somniumism commented Jan 10, 2020 •
edited
Loading

@sgkim126 I see : ) I will add some benchmark tests to compare the performance. Thank you for your advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somniumism somniumism

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sgkim126 @kseo @foriequal0 @somniumism