Skip to content

Fix analyze script, work on reducing bundle size #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qualitymanifest wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix analyze script, work on reducing bundle size #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08436be
Fix analyze script
qualitymanifest Feb 2, 2020
36647d2
Lazy load LocationTable
qualitymanifest Feb 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/containers/LocationTablePage/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,13 @@
*
*/

import React from 'react';
import React, { lazy, Suspense } from 'react';
import Grid from '@material-ui/core/Grid';
import CircularProgress from '@material-ui/core/CircularProgress';
import { FormattedMessage } from 'react-intl';
import LocationTable from '../../components/LocationTable';

import messages from './messages';
const LocationTable = lazy(() => import('../../components/LocationTable'));

export default function LocationTablePage() {
return (
Expand All @@ -22,7 +24,9 @@ export default function LocationTablePage() {
<h1 className="headline">
<FormattedMessage {...messages.header} />
</h1>
<LocationTable />
<Suspense fallback={<CircularProgress />}>
<LocationTable />
</Suspense>
</Grid>
);
}
2 changes: 1 addition & 1 deletion internals/scripts/analyze.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const progress = animateProgress('Generating stats');

// Generate stats.json file with webpack
shelljs.exec(
'webpack --config internals/webpack/webpack.prod.babel.js --profile --json > stats.json',
'cross-env NODE_ENV=production webpack --config internals/webpack/webpack.prod.babel.js --json > stats.json',
addCheckMark.bind(null, callback), // Output a checkmark on completion
);

Expand Down