Skip to content

Commit 8e7d17b

Browse files
selulclaude
andcommitted
fix: type update_timeline param as mixed[] and drop stale phpstan baseline
The docblock now uses a typed array (mixed[]) so it satisfies both the updated PHPCS (MissingParamType) and PHPStan (missingType.iterableValue). Removed the now-obsolete phpstan-baseline.neon entry that ignored the old "parameter $new_events with no type specified" error, which no longer occurs and would otherwise be reported as an unmatched ignore. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent deb514b commit 8e7d17b

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

includes/admin/models/class-rop-scheduler-model.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -535,8 +535,8 @@ private function get_week_start( $start = 0 ) {
535535
/**
536536
* Update the events timeline.
537537
*
538-
* @param array $new_events New events timeline.
539-
* @param string $account_id account id.
538+
* @param mixed[] $new_events New events timeline.
539+
* @param string $account_id account id.
540540
*
541541
* @return bool Success or not.
542542
*/

phpstan-baseline.neon

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3078,12 +3078,6 @@ parameters:
30783078
count: 1
30793079
path: includes/admin/models/class-rop-scheduler-model.php
30803080

3081-
-
3082-
message: '#^Method Rop_Scheduler_Model\:\:update_timeline\(\) has parameter \$new_events with no type specified\.$#'
3083-
identifier: missingType.parameter
3084-
count: 1
3085-
path: includes/admin/models/class-rop-scheduler-model.php
3086-
30873081
-
30883082
message: '#^PHPDoc tag @SuppressWarnings has invalid value \(\(PHPMD\.UnusedLocalVariable\)\)\: Unexpected token "\.UnusedLocalVariable\)", expected ''\)'' at offset 89 on line 4$#'
30893083
identifier: phpDoc.parseError

0 commit comments

Comments
 (0)