[Mutes] Unable to remove timeouts if a default mute duration is configured

[Coltuna]

What component of Red (cog, command, API) would you like to see improvements on?

Mutes

Describe the enhancement you're suggesting.

When a mod uses [p]timeout @member and if no time is passed then it doesn't uses the default mute time setting instead it removes the timeout incase user is already timedout.
Additionally, if we start using the default mute time setting, then there is no current way to remove the timeout.

Anything else?

No response

[Coltuna]

As per the discussion in server, we are to use default time if nothing is passed but if default time is not set then it will be passed as None which will result in no timeout. In case of [p]mute it works cause role is added for indefinite amount of time, but for timeout we need to maybe set a default time by our guess in case no time is passed as argument and default time is also not set.

[Flame442]

I'm not seeing the described issue that [p]timeout <user> fails to use the default mute time setting, if one is actually set. If you can give some more specific reproduction steps for that issue, please do.

---

Currently, if no duration is passed and no default duration is set, the initial None value persists which results in an un-timeout. The issue with this approach is that it leaves no way to un-timeout a user when a default duration is set, as you described. This issue does need to be addressed.

Red-DiscordBot/redbot/cogs/mutes/mutes.py

Lines 1155 to 1174 in dd3b9a0

	duration = None
	if until:
	duration = time_and_reason.get("duration")
	if duration and duration > timedelta(days=28):
	await ctx.send(_(MUTE_UNMUTE_ISSUES["mute_is_too_long"]))
	return
	length = humanize_timedelta(timedelta=duration)
	time = _(" for {length} until {duration}").format(
	length=length, duration=discord.utils.format_dt(until)
	)
	else:
	default_duration = await self.config.guild(ctx.guild).default_time()
	if default_duration:
	duration = timedelta(seconds=default_duration)
	until = ctx.message.created_at + duration
	length = humanize_timedelta(seconds=default_duration)
	time = _(" for {length} until {duration}").format(
	length=length, duration=discord.utils.format_dt(until)
	)