Skip to content

CU-869azvxkn: Remove duplicate lines for transformers dependency. #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

CU-869azvxkn: Remove duplicate lines for transformers dependency. #204

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff06851
CU-869azvxkn: Remove duplicate lines for transformers dependency.
mart-r Oct 29, 2025
e91b59f
CU-869azvxkn: Remove duplicate lines that were needed for 3.9 support
mart-r Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions medcat-v2/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[project]
name = "medcat"

version = "2.0.0-dev"
version = "2.2.0-dev"

description = "Medical Concept Annotation Toolkit (v2)"

Expand Down Expand Up @@ -89,8 +89,6 @@ spacy = [
]
meta_cat = [
"transformers>=4.41.0,<5.0", # avoid major bump
# Transformers 4.57 doesn't support 3.9
"transformers!=4.57.0; python_version == '3.9'",
"peft>0.8.2,<1.0",
"torch>=2.4.0,<3.0",
"scikit-learn>=1.1.3,<2.0",
Expand All @@ -103,23 +101,15 @@ dict_ner = [
]
deid = [
"datasets>=2.2.2,<3.0.0",
# Transformers 4.57 doesn't support 3.9
"transformers!=4.57.0; python_version == '3.9'",
Copy link
Collaborator

@alhendrickson alhendrickson Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a loose thought, could you even remove the non-duplicated line now? If we don't specifically support 3.9 anymore. May as well keep it I guess just a thought.

Copy link
Collaborator Author

@mart-r mart-r Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good shout!

"transformers>=4.41.0,<5.0", # avoid major bump
# Transformers 4.57 doesn't support 3.9
"transformers!=4.57.0; python_version == '3.9'",
"scikit-learn>=1.1.3,<2.0",
"torch>=2.4.0,<3.0",
# since 3.13 we need to use later version of scipy for it
"scipy<1.14; python_version < '3.13'",
"scipy>=1.14; python_version >= '3.13'",
]
rel_cat = [
# Transformers 4.57 doesn't support 3.9
"transformers!=4.57.0; python_version == '3.9'",
"transformers>=4.41.0,<5.0", # avoid major bump
# Transformers 4.57 doesn't support 3.9
"transformers!=4.57.0; python_version == '3.9'",
"scikit-learn>=1.1.3,<2.0",
"torch>=2.4.0,<3.0",
]
Expand Down
Loading