Fix themeing of nodes#12712
Open
AustinMroz wants to merge 2 commits into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR applies the ChangesTheme Styling and Palette Integration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ❌ 1665 passed, 2 failed❌ Failed Tests📊 Browser Reports
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #12712 +/- ##
===========================================
- Coverage 76.09% 61.33% -14.77%
===========================================
Files 1559 1448 -111
Lines 95378 75006 -20372
Branches 25916 21170 -4746
===========================================
- Hits 72580 46002 -26578
- Misses 22042 28650 +6608
+ Partials 756 354 -402
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1147 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In moving styling to
documentElement, #9516 introduced a regression preventing themes from styling nodes.Note: Some elements (like the app mode toggle) are themed using different variables (
--secondary-backgroundinstead of--component-node-background). I think the sanest approach is to define--secondary-backgroundto be--component-node-backgroundby default, but that feels better handled as a followup PR